Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)

Jana Iyengar <notifications@github.com> Sat, 11 May 2019 00:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAA5A120114 for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 17:48:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.392
X-Spam-Level:
X-Spam-Status: No, score=-6.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YZDnyu-Bq8Fy for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 17:48:48 -0700 (PDT)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDBE41201DB for <quic-issues@ietf.org>; Fri, 10 May 2019 17:48:47 -0700 (PDT)
Date: Fri, 10 May 2019 17:48:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557535727; bh=014NHjNoe9QC5x+/LOa9YNOs04x7BuILqdB6SfPDH5k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wfg9ksOH7c7AC8YaJz+H/rXquRlqcx8/9d6vjkIpNNwzZ/XO13cvT/Vhjuj64/dQZ QOvjhShOH7pBISHDFMlZRabBJpMxl1loNUuG4XmuxFy4Wupbp0S1QCFC7fYekhA23S j1O2p8Dtyuq77K/3vHcXL6CxvMsNEmJ32EGhdN18=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7TECHSARVADU75HEV24NHG5EVBNHHBUAC2DE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2642/c491465487@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2642@github.com>
References: <quicwg/base-drafts/pull/2642@github.com>
Subject: Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd61beedd2c9_717d3feb3e0cd96085614"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sJzrW5kIbAhAluqydGWOSFdK6k0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 May 2019 00:48:50 -0000

@ianswett: Good catch! It's useful to go back to the principle we have in place: if we want a PTO running, we need to have an ack-eliciting packet outstanding. I don't think there's a strong enough argument to create an exception here, so I agree that we should change this to always sending a PING when the timer goes off and there's nothing to send.

Since the title here is quite clearly the opposite of that, in the interest of transparency, I propose that you close this PR in favor of a new one that says send PING (and stack this new PR on top of #2655).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2642#issuecomment-491465487