Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)

Marten Seemann <notifications@github.com> Mon, 19 March 2018 12:17 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DFFDC12785F for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 05:17:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.028
X-Spam-Level:
X-Spam-Status: No, score=-2.028 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ngdzIwKpw17I for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 05:17:04 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C24D6127775 for <quic-issues@ietf.org>; Mon, 19 Mar 2018 05:17:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Z0ZeoZFU0bZT7CX3q6hh1mTWP7Y=; b=jAy35wREXAvuyugB bTY7NKQdNhpBh/Ju6nL1H003QiBD6MCfQkm/k9GLMk/WeCU8Ydy5ZMwf8pUBeJXo noQ3phsH+clA/VV5bbj7QQxksaTAfi5R+6XGMuzVfpGQRLCTvvjzU7R0j4VZpAy+ otNB1PrOaltZzgNLmUDL4ksa4xw=
Received: by filter0233p1iad2.sendgrid.net with SMTP id filter0233p1iad2-14241-5AAFAA3E-1B 2018-03-19 12:17:02.765113122 +0000 UTC
Received: from smtp.github.com (out-2.smtp.github.com [192.30.252.193]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id oPv6gfhzTXqhr6RhsAHDPA for <quic-issues@ietf.org>; Mon, 19 Mar 2018 12:17:02.579 +0000 (UTC)
Date: Mon, 19 Mar 2018 12:17:02 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdfdd08757aa81b7b553d7d1bcf102d7860589f4392cf0000000116c76c3e92a169ce12418d6a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1231/review/104937071@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1231@github.com>
References: <quicwg/base-drafts/pull/1231@github.com>
Subject: Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aafaa3e7e42f_7e112b128dd14ec414131e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1ri+K9NAydEHTEtvQz5Dm72v3mQ5moMc5lRH Fzn/IIqGCi1T5u3geHLuwpbCx+ZbUZcKXvbN8aDi5WSRdR4yIxSY23yhRXWdLQm1qJ3FK+VenAj/vD qKj6fboykTMsvntmryZRSdm+wnItIB5Hj+SWGXpYIPSNPnPr5g97u+7Ps55bmlVvzdWxoWUHM9A8Sr A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sW-C7hvZcVPNkQfN6acH2i0hJbg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 12:17:06 -0000

marten-seemann commented on this pull request.



>  
 To limit ACK blocks to those that have not yet been received by the sender, the
 receiver SHOULD track which ACK frames have been acknowledged by its peer.  Once
 an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
 acknowledged again.
 
-A receiver that is only sending ACK frames will not receive acknowledgments for
-its packets.  Sending an occasional MAX_DATA or MAX_STREAM_DATA frame as data is
-received will ensure that acknowledgements are generated by a peer.  Otherwise,
-an endpoint MAY send a PING frame once per RTT to solicit an acknowledgment.
+Because ACK-only packets are not acknowledged, a receiver that is only
+sending ACK frames will only receive acknowledgements for its packets
+if the sender piggybacks them on other packets. In order to enable

The text as it stands makes sense: **If** a peer wants an ACK for an ACK (e.g. to prune the lowest acked packet), it can include a retransmittable frame. This depends on which ack-pruning algorithm it uses, and it has nothing to do with how frames are bundled.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1231#discussion_r175414525