Re: [quicwg/base-drafts] Add an appendix containing test vectors for "Initial". (#1573)
Masaori Koshiba <notifications@github.com> Fri, 20 July 2018 03:30 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2F7D9130E6E for <quic-issues@ietfa.amsl.com>; Thu, 19 Jul 2018 20:30:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ad-9EHO-h1Ll for <quic-issues@ietfa.amsl.com>; Thu, 19 Jul 2018 20:30:05 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B5551277D2 for <quic-issues@ietf.org>; Thu, 19 Jul 2018 20:30:05 -0700 (PDT)
Date: Thu, 19 Jul 2018 20:30:03 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532057403; bh=2baCAtF5SRb8Rq60SYZWaWVucyPs0Ermbf1TEdRlkBc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HO0Wq4SrlLxlQBRejK52L1B7cXHdTyIq88TprszxSTnwe7rKMJHQrY/nX0fmOGckw I45QR82e35TucQB1UMbE9qTMHhcP4zm7pyG/pX7hyF0B6Sb5IzCunkfq26tYwYGF+q a1+ORdm5FNpk/yBgmuUM+DNHt+w8zDQmECKVXYqM=
From: Masaori Koshiba <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab91c2b7363d9e40b7ba605512c2b251253e9d3d2692cf000000011769193b92a169ce145eeded@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1573/c406478811@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1573@github.com>
References: <quicwg/base-drafts/pull/1573@github.com>
Subject: Re: [quicwg/base-drafts] Add an appendix containing test vectors for "Initial". (#1573)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b51573bc77d_53a33fc9d34ccf5c114715"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: masaori335
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sWUSCNZPJc35qn23P6i5TR7XAwk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jul 2018 03:30:07 -0000
I tried @ekr's test vector on the list and this test vector. My code passed with ekr's test vector, but failed with this test vector. I got below values. ("initial secret" is same, but others are not same) ``` initial secret : a572b0245af1eddf5c61c6e3f7f9304ca66bfb4caaf76567d5cb8dd1dc4e820b client in secret: 9f536457f32a1e0ae864bcb3caf1235110630e1d1fb33835bd054170f99bf7dc key: f2928f2614ad6c20b9bd008e9c89631c iv: ab950b0198637978cf44aab9 pn: 68c3f64e2d6634412b8e3294628d76f1 server in secret: b087dcd7478dda8a858fbf3d605c888586c0a3a9875423ad4f114f0ba38e5a2e key: f56817d0fc595cfc0a2b0bcfb18735ec iv: 3205035a3c937c902ee4f4d6 pn: a313c86d1373ecbccb3294b14974226c ``` I doubt that there is a bug around `HKDF-Expand-Label` implementation. Because the "info" parameter of `HKDF-Expand` is changed in draft-13. If understand correctly, it's `HkdfLabel` (defined in TLS 1.3) and it has `context<0..255>` field. Without the context field, I got exact same values of this test vector. QUIC draft-12 ``` struct { uint16 length = Length; opaque label<6..255> = "QUIC " + Label; } QhkdfExpandInfo; ``` TLS 1.3 (QUIC draft-13) ``` struct { uint16 length = Length; opaque label<7..255> = "tls13 " + Label; opaque context<0..255> = Context; } HkdfLabel; ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1573#issuecomment-406478811
- [quicwg/base-drafts] Add an appendix containing t… Rui Paulo
- Re: [quicwg/base-drafts] Add an appendix containi… Masaori Koshiba
- Re: [quicwg/base-drafts] Add an appendix containi… Rui Paulo
- Re: [quicwg/base-drafts] Add an appendix containi… Christian Huitema
- Re: [quicwg/base-drafts] Add an appendix containi… Christian Huitema
- Re: [quicwg/base-drafts] Add an appendix containi… Rui Paulo
- Re: [quicwg/base-drafts] Add an appendix containi… Martin Thomson
- Re: [quicwg/base-drafts] Add an appendix containi… Christian Huitema
- Re: [quicwg/base-drafts] Add an appendix containi… Martin Thomson
- Re: [quicwg/base-drafts] Add an appendix containi… Christian Huitema
- Re: [quicwg/base-drafts] Add an appendix containi… Martin Thomson
- Re: [quicwg/base-drafts] Add an appendix containi… Kazuho Oku
- Re: [quicwg/base-drafts] Add an appendix containi… Rui Paulo
- Re: [quicwg/base-drafts] Add an appendix containi… Rui Paulo
- Re: [quicwg/base-drafts] Add an appendix containi… Rui Paulo
- Re: [quicwg/base-drafts] Add an appendix containi… Rui Paulo
- Re: [quicwg/base-drafts] Add an appendix containi… Martin Thomson