Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)

Jana Iyengar <notifications@github.com> Sat, 11 May 2019 00:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C0EA12009C for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 17:36:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8kAQ-cQIr9gq for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 17:36:49 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BF8CD120043 for <quic-issues@ietf.org>; Fri, 10 May 2019 17:36:48 -0700 (PDT)
Date: Fri, 10 May 2019 17:36:47 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557535007; bh=a3WWSxXAoLRmEU5ardp35Meiji6WHpUxOSG2R5y2PwI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=H4UvmbgsON6RmSjYQ10170z7jMPltMeeR6wJTExZriMa29yS3cJOxk9Igb831XFQK RecbZqDmL6Il+vOG3pr0zh5Z67iRoMOi7gYTaStjpCTYoyP5I9N0H68SGgsnwcosHw HBbEF2iqxNaTtbl9Sh9yb4U3UXFrIhAQ01zGyE0Y=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZAKA6GFX2QNTNHIOV24NFZ7EVBNHHBUAC2DE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2642/review/236353686@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2642@github.com>
References: <quicwg/base-drafts/pull/2642@github.com>
Subject: Re: [quicwg/base-drafts] Don't send PING in Initial or Handshake (#2642)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd6191fb3445_133c3fb63c2cd96810045c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/s_esMofG8BpRX0pHO_wfyW-0jzk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 May 2019 00:36:51 -0000

janaiyengar commented on this pull request.



> @@ -538,11 +538,14 @@ MUST ensure that the crypto retransmission timer is set if there is
 unacknowledged crypto data or if the client does not yet have 1-RTT keys.
 If the crypto retransmission timer expires before the client has 1-RTT keys,
 it is possible that the client may not have any crypto data to retransmit.
-However, the client MUST send a new packet, containing only PING or PADDING
-frames if necessary, to allow the server to continue sending data. If
-Handshake keys are available to the client, it MUST send a Handshake packet,
-and otherwise it MUST send an Initial packet in a UDP datagram of at least
-1200 bytes.
+However, the client MUST send a new packet, containing only PADDING frames if
+necessary, to allow the server to continue sending data. If Handshake keys
+are available to the client, it MUST send a Handshake packet, and otherwise
+it MUST send an Initial packet in a UDP datagram of at least 1200 bytes.
+
+Because packets only containing PADDING do not elicit an acknowledgement,
+they may never be acknowledged, but they are removed from bytes in flight
+when the client gets Handshake keys and the Initial keys are discarded.

Suggested rewording:
"Because the server will eventually discard Initial and Handshake keys, and because packets containing only PADDING frames do not elicit an acknowledgement, it is possible that no acknowledgement is ever received for these additional packets.  They are however eventually removed from the count of bytes in flight when the client discards the corresponding keys (see {{discarding-keys}})."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2642#pullrequestreview-236353686