IETF Logo Mail Archive

Re: [quicwg/base-drafts] [qpack] Add comment explaining static table (#3576)

Martin Thomson <notifications@github.com> Tue, 14 April 2020 01:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B9F83A2295 for <quic-issues@ietfa.amsl.com>; Mon, 13 Apr 2020 18:18:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.863
X-Spam-Level:
X-Spam-Status: No, score=-1.863 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j9UZEQM8uyOb for <quic-issues@ietfa.amsl.com>; Mon, 13 Apr 2020 18:18:11 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4D8603A2293 for <quic-issues@ietf.org>; Mon, 13 Apr 2020 18:18:11 -0700 (PDT)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 51E4C8C16B3 for <quic-issues@ietf.org>; Mon, 13 Apr 2020 18:18:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586827090; bh=Vu1ub96TnO3aVf+Q10biljefMLobHsHVCzKgRYA0UzE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=o0tVV+R3QeqqZ+KnwPxhSWpLZPXr0z44bX8SomdqT+buPmrSfOiuDfW4RlYiZ1tEO otXp/fNnQIqC7vSH1OmlaWtS/pioGJoZHe1VCRzWHX0jrBbWkufiR8+b6J0vUI4KzN bT+D76gQLZLlK0Yw0JtIbtPY6/nA4jvi33+ePYa8=
Date: Mon, 13 Apr 2020 18:18:10 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2OMVQZF37TX4CK5254UDYFFEVBNHHCHNULTU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3576/review/392540302@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3576@github.com>
References: <quicwg/base-drafts/pull/3576@github.com>
Subject: Re: [quicwg/base-drafts] [qpack] Add comment explaining static table (#3576)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e950f5242f6c_69943ff3528cd9648329a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/scgWE6RafhUP3rTc_u3_Xdw1a3A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2020 01:18:13 -0000

@martinthomson commented on this pull request.



> +this methodology, some of the entries may be inconsistent.  Notably,
+"content-type: text/plain; charset=utf-8" appears twice with two different
+whitespace encodings (entries 52 and 54).

```suggestion
this methodology, some of the entries may be inconsistent.
```

It's probably enough to observe that there are inconsistencies that derive from the source data.

> @@ -1199,6 +1199,12 @@ are registered in the "HTTP/3 Error Code" registry established in {{HTTP3}}.
 
 # Static Table
 
+This table was generated by analyzing actual internet traffic in 2018 and
+manually crafting the table for optimal compression of common headers.  Due to

What does "manually crafting" mean?  I think that you mean manually removing obvious redundancies and (other stuff we/Mike did).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3576#pullrequestreview-392540302

v2.23.0 | Report a Bug | By Email