Date: Mon, 13 Apr 2020 18:18:10 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2OMVQZF37TX4CK5254UDYFFEVBNHHCHNULTU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3576/review/392540302@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3576@github.com>
References: <quicwg/base-drafts/pull/3576@github.com>
Subject: Re: [quicwg/base-drafts] [qpack] Add comment explaining static table
 (#3576)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e950f5242f6c_69943ff3528cd9648329a";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/scgWE6RafhUP3rTc_u3_Xdw1a3A>


----==_mimepart_5e950f5242f6c_69943ff3528cd9648329a
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@martinthomson commented on this pull request.



> +this methodology, some of the entries may be inconsistent.  Notably,
+"content-type: text/plain; charset=utf-8" appears twice with two different
+whitespace encodings (entries 52 and 54).

```suggestion
this methodology, some of the entries may be inconsistent.
```

It's probably enough to observe that there are inconsistencies that derive from the source data.

> @@ -1199,6 +1199,12 @@ are registered in the "HTTP/3 Error Code" registry established in {{HTTP3}}.
 
 # Static Table
 
+This table was generated by analyzing actual internet traffic in 2018 and
+manually crafting the table for optimal compression of common headers.  Due to

What does "manually crafting" mean?  I think that you mean manually removing obvious redundancies and (other stuff we/Mike did).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3576#pullrequestreview-392540302
----==_mimepart_5e950f5242f6c_69943ff3528cd9648329a
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p></p>=0D
<p><b>@martinthomson</b> commented on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3576#discussi=
on_r407809065">draft-ietf-quic-qpack.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; +this methodology, some of the entries may=
 be inconsistent.  Notably,=0D
+&quot;content-type: text/plain; charset=3Dutf-8&quot; appears twice with=
 two different=0D
+whitespace encodings (entries 52 and 54).=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-this methodology, some of the entries may be =
inconsistent.  Notably,=0D
-"content-type: text/plain; charset=3Dutf-8" appears twice with two diffe=
rent=0D
-whitespace encodings (entries 52 and 54).=0D
+this methodology, some of the entries may be inconsistent.=0D
</pre>=0D
=0D
<p>It's probably enough to observe that there are inconsistencies that de=
rive from the source data.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3576#discussi=
on_r407809218">draft-ietf-quic-qpack.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -1199,6 +1199,12 @@ are registered in t=
he &quot;HTTP/3 Error Code&quot; registry established in {{HTTP3}}.=0D
 =0D
 # Static Table=0D
 =0D
+This table was generated by analyzing actual internet traffic in 2018 an=
d=0D
+manually crafting the table for optimal compression of common headers.  =
Due to=0D
</pre>=0D
<p>What does "manually crafting" mean?  I think that you mean manually re=
moving obvious redundancies and (other stuff we/Mike did).</p>=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3576#pullrequestreview-392540302">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AFTOJ=
K2I53BSVRNBF76JP5LRMO2VFANCNFSM4MHIUIHQ">unsubscribe</a>.<img src=3D"http=
s://github.com/notifications/beacon/AFTOJKYCP5WWCTD6QB24DCDRMO2VFA5CNFSM4=
MHIUIH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZ=
GOC5S3BDQ.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3576#pullrequestrev=
iew-392540302",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3576#pullrequestreview=
-392540302",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5e950f5242f6c_69943ff3528cd9648329a--