Re: [quicwg/base-drafts] Clarify what to do when ALPN negotiation fails (#2483)

Jana Iyengar <notifications@github.com> Tue, 05 March 2019 23:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1628013108C for <quic-issues@ietfa.amsl.com>; Tue, 5 Mar 2019 15:00:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EXxplw1Oi5ZA for <quic-issues@ietfa.amsl.com>; Tue, 5 Mar 2019 15:00:57 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EC797131106 for <quic-issues@ietf.org>; Tue, 5 Mar 2019 15:00:56 -0800 (PST)
Date: Tue, 05 Mar 2019 15:00:55 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1551826855; bh=IsmZbap1huKDLbuhxbLXGm680q3+d8od+YYeWL16YGU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=gFrqir52jTuedUL81Pbv7C+AhpOYJ3Df7WojNTtAPAS16OzY+Chu4IHoSmDwon2b3 t4AqY+anYcNx3sWWz0bfOEpsoeZecBIyMIrXfjls949YW23ZgbUy5dfYPSPEvHmJLB kmxaFtyWhdkHJMbRWFO8trYz1Po+tM+qTDIAYM9M=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc3a981fc5acf47e287bd5afcd04215fe331a904192cf000000011896c1a792a169ce18955108@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2483/review/210966700@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2483@github.com>
References: <quicwg/base-drafts/pull/2483@github.com>
Subject: Re: [quicwg/base-drafts] Clarify what to do when ALPN negotiation fails (#2483)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c7effa7c4eff_75283fb32f6d45bc1294e0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sfvlu0CXR19dKU4SDEUVpaRDHd8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Mar 2019 23:00:59 -0000

janaiyengar commented on this pull request.



> @@ -1216,7 +1216,9 @@ negotiation.  TLS uses Application Layer Protocol Negotiation (ALPN)
 {{!RFC7301}} to select an application protocol.  Unless another mechanism is
 used for agreeing on an application protocol, endpoints MUST use ALPN for this
 purpose.  When using ALPN, endpoints MUST abort a connection if an application

This isn't within your change, but what  does "abort" mean. Should this be "drop QUIC connection state"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2483#pullrequestreview-210966700