Re: [quicwg/base-drafts] Describe PMTU probing that includes source connection ID for routing … (#2402)

Kazuho Oku <notifications@github.com> Mon, 04 February 2019 02:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8AC26130DE4 for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 18:39:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A8K2CAkArB61 for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 18:38:59 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 34989126F72 for <quic-issues@ietf.org>; Sun, 3 Feb 2019 18:38:59 -0800 (PST)
Date: Sun, 03 Feb 2019 18:38:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549247937; bh=uk/nL2fxCw0GTCppxd6K/jHXGOGjJ4pVQ/kl6s918ak=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=C5K/pgWEduvPLqPao5MN29dHSETTA2Qv6ttXQRNrqRvSe89UuGNMiuvpculO76bLy j/0QUxTo21aNufGfAX+4b77S21JM5d0gyWBDBDXi6WQg2+xPX6Wr3z5o99zL/Ti68m C0B5e2pO+Zbo+dCpxgvXuFsbvikkcVPB2c1XtxJE=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd87b4acd5f50f36255e3a329ad2d2543119edd3f92cf00000001186f67c192a169ce1833165d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2402/review/199424601@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2402@github.com>
References: <quicwg/base-drafts/pull/2402@github.com>
Subject: =?UTF-8?Q?Re:_[quicwg/base-drafts]_Describe_PMTU_probing_that?= =?UTF-8?Q?_includes_source_connection_ID_for_routing_=E2=80=A6_=28#2402=29?=
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c57a5c198502_5d873f97324d45b466766"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/skavbivhGQZCzW5Y5p9amgDjuUU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 02:39:02 -0000

kazuho commented on this pull request.

Looks mostly fine to me.

Besides some minor comments (see below), I think it might be a good idea to add a reference to this section from "12.2. Coalescing Packets".

> @@ -3274,6 +3274,22 @@ The considerations for processing ICMP messages in the previous section also
 apply if these messages are used by DPLPMTUD.
 
 
+### PMTU Probes Containing Source Connection ID
+
+Endpoints that rely on the destination connection ID for routing QUIC packets
+are likely to require that connection ID included in PMTU probe packets in order
+to route resulting ICMP messages ({{icmp-pmtud}}) back to the correct endpoints.
+
+Only long header packets ({{long-header}}) contain source connection IDs, but
+long header packets will not be acknowledged once the connection has been
+established.  One way to construct a PMTU probe is to coalesce (see
+{{packet-coalesce}}) a Handshake packet ({{packet-handshake}}) with a short

It might make sense to:
* Call the datagram "a probe", rather than referring to the short header packet as "a probe".
* it might be better to suggest use of _any_ coalescible long header packet rather than specifically suggesting the use of a Handshake packet.

Therefore something like: _One way to construct a PMTU probe is to coalesce a Long header packet with a Length field and a short header packet into a single UDP datagram, If the datagram reaches the endpoint, the short header packet will be acknowledged. If the datagram elicits an ICMP message, that message will likely contain the source connection ID within the quoted portion of the datagram._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2402#pullrequestreview-199424601