Re: [quicwg/base-drafts] Simplify UpdateRtt pseudocode (#2610)
Martin Thomson <notifications@github.com> Fri, 12 April 2019 06:52 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 695EF120043 for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 23:52:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.002
X-Spam-Level:
X-Spam-Status: No, score=-8.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ARx0xjei2s5R for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 23:52:21 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 786B91200BA for <quic-issues@ietf.org>; Thu, 11 Apr 2019 23:52:21 -0700 (PDT)
Date: Thu, 11 Apr 2019 23:52:19 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555051939; bh=cYmEyWORKWYquRvuuprKT9iHcvfywpIW/EURKjXC8+8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SKlPS8D7hgohJCCB1OXgMmhOLumTsXoSyfZWFzsyVC2HUiJvP3P/bGXLi90OSRr+X bqcSo87IUbm6GKXr3TED8F0rhmY1Yb4wBv1ll4QGsyDI6huRAHLDxTL7my5t4grERO GLVbQ140ScVMyISkNFV7kl1WJyiIivlgaWcBqiwI=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab49cc241747ccc606d42133552c14a05f7042f12392cebabd682392a169ce19c5c948@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2610/review/225919515@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2610@github.com>
References: <quicwg/base-drafts/pull/2610@github.com>
Subject: Re: [quicwg/base-drafts] Simplify UpdateRtt pseudocode (#2610)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb035a3e3ecf_23203fb5b4cd45c0137446"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sngGXs0czz2-dRJW33tYr7-2Z6k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Apr 2019 06:52:25 -0000
martinthomson approved this pull request.
This looks good.
> @@ -1101,22 +1101,24 @@ OnAckReceived(ack, pn_space):
UpdateRtt(latest_rtt, ack_delay):
latest_rtt probably shouldn't be global.
> @@ -1101,22 +1101,24 @@ OnAckReceived(ack, pn_space):
UpdateRtt(latest_rtt, ack_delay):
+ if (smoothed_rtt == 0):
+ // First RTT sample.
I don't think so. #2607 covers this though.
> adjusted_rtt = latest_rtt
- if (latest_rtt - min_rtt > ack_delay):
+ if (latest_rtt > min_rtt + ack_delay):
adjusted_rtt = latest_rtt - ack_delay
The prose relies on latest_rtt in descriptions. Adjusting that value directly would confuse things.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2610#pullrequestreview-225919515
- [quicwg/base-drafts] Simplify UpdateRtt pseudocod… Jana Iyengar
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… Lars Eggert
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… Lars Eggert
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… Lars Eggert
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… Lars Eggert
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… Martin Thomson
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… Marten Seemann
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… ianswett
- Re: [quicwg/base-drafts] Simplify UpdateRtt pseud… Jana Iyengar