Re: [quicwg/base-drafts] Only ack headers that have non-zero declared Largest Reference (#1605)
Mike Bishop <notifications@github.com> Fri, 27 July 2018 23:40 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCDEB1277C8 for <quic-issues@ietfa.amsl.com>; Fri, 27 Jul 2018 16:40:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X9hq95f1SGQJ for <quic-issues@ietfa.amsl.com>; Fri, 27 Jul 2018 16:40:49 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26915130DE4 for <quic-issues@ietf.org>; Fri, 27 Jul 2018 16:40:49 -0700 (PDT)
Date: Fri, 27 Jul 2018 16:40:48 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532734848; bh=fHRGpQgdwCwa86n08Za3JoCt1kFnJRCMR3JKnZisTGY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VgyT4HCqUAgspwNDjXSmwelhY3uq4NU8jxbKQdvY9sl8AOMkBas2bA4x1ykvvJ6tY RI9Xz9I3nhek4Pv8Y3cUyBnrCmwCkniFARJ4xgS/RjK42IDxeVJQyjKFbvLmIRmeoK r8PUrh3TqunTe/dQ9p6gU3HEOykGKcijx/RCcBrw=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7ae688d6deea15ecbcb8f229e9d9fafdc2413fd692cf0000000117736f8092a169ce14885428@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1605/review/141295927@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1605@github.com>
References: <quicwg/base-drafts/pull/1605@github.com>
Subject: Re: [quicwg/base-drafts] Only ack headers that have non-zero declared Largest Reference (#1605)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b5bad803b51e_37653ffb486d45c41070c1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/socYRpXJ5hvxuOI_LVJvdBwrc04>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jul 2018 23:40:51 -0000
MikeBishop approved this pull request. I thought it might be worth adding a matching reference where tracking of header blocks is discussed, noting that blocks with no references don't need to be tracked and won't be acknowledged. However, I don't see any such text that doesn't still hold true, so I think this is fine. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1605#pullrequestreview-141295927
- Re: [quicwg/base-drafts] Only ack headers that ha… Martin Thomson
- [quicwg/base-drafts] Only ack headers that have n… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Only ack headers that ha… Mike Bishop
- Re: [quicwg/base-drafts] Only ack headers that ha… Martin Thomson
- Re: [quicwg/base-drafts] Only ack headers that ha… Martin Thomson
- Re: [quicwg/base-drafts] Only ack headers that ha… afrind
- Re: [quicwg/base-drafts] Only ack headers that ha… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Only ack headers that ha… afrind