Re: [quicwg/base-drafts] No max_ack_delay in handshake alarm (#1817)
martinduke <notifications@github.com> Mon, 01 October 2018 18:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8CE88130E92 for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 11:34:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.454
X-Spam-Level:
X-Spam-Status: No, score=-8.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zc3NqSUVKgYx for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 11:34:20 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D9FD8130E6B for <quic-issues@ietf.org>; Mon, 1 Oct 2018 11:34:19 -0700 (PDT)
Date: Mon, 01 Oct 2018 11:34:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538418858; bh=qqqPKkuutf3WjEFrN0kllXOTrvmuTO0Rf0qLyjjKXRU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=R/Bhq7cZ2Zjdpj5zNGHdA8DLJGgeP9/Zm5WjajD5E2jvSdO1O2m+XgMKRpkP1TEeN 0TSBlCdMTpqNE/cDT9cIXAvwBX9sa2/wPNpai4iDs8OwLIfQ6NMdCTiv4IwXu/YafB AsM83siMXMZJ6ANrf+Q3kIRYFr5FKQJ2KxCxDb3s=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab45905929dc3b45ce8bdbc6d6917e627d4c10d43392cf0000000117ca2aaa92a169ce15ca3b43@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1817/review/160428756@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1817@github.com>
References: <quicwg/base-drafts/pull/1817@github.com>
Subject: Re: [quicwg/base-drafts] No max_ack_delay in handshake alarm (#1817)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb268aac0754_6fcd3f8df82d45b81043e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sqlV788sNnUljrJJCKUOFF-6zKc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2018 18:34:23 -0000
martinduke approved this pull request. Given that there's pretty much always data to send, the only possible problem I see is with the final ack of client FINISHED. But meh. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1817#pullrequestreview-160428756