Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)

Alessandro Ghedini <notifications@github.com> Wed, 20 March 2019 18:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 423A5131216 for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 11:28:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.001
X-Spam-Level:
X-Spam-Status: No, score=-3.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oFYbjG5HZlty for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 11:28:27 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28842131210 for <quic-issues@ietf.org>; Wed, 20 Mar 2019 11:28:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=pA5E2WmIfwKzwqD9xHxFQ+3L6CQ=; b=guAVg7ly4vnQ/IIt veXjznTmTLD1BXtlVsCtjcjmQTlJrzwYzGb/tx69xo7BoGR8mGYqxi1RxBTg93/Q GG8o5Ki4BR6DaTWZ6dIsADeJsAb1xNEUdGlTDTmy3ytwl5Ge2SClel+tKErlWwF8 LM1N/LvedzksKE0G2I3bGq+qstE=
Received: by filter1350p1mdw1.sendgrid.net with SMTP id filter1350p1mdw1-31674-5C92864A-7 2019-03-20 18:28:26.049719685 +0000 UTC m=+169127.137837138
Received: from github-lowworker-27304fa.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id j43DiPAqTEuzT_Mi-CUJjw for <quic-issues@ietf.org>; Wed, 20 Mar 2019 18:28:25.986 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-27304fa.cp1-iad.github.net (Postfix) with ESMTP id EE45E2C0072 for <quic-issues@ietf.org>; Wed, 20 Mar 2019 11:28:25 -0700 (PDT)
Date: Wed, 20 Mar 2019 18:28:26 +0000
From: Alessandro Ghedini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf6b0c46f2cec99d888762c6409baf61a550fbd4592cf0000000118aa484992a169ce1931c3e6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2529/review/216906375@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2529@github.com>
References: <quicwg/base-drafts/pull/2529@github.com>
Subject: Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c928649eca1c_5fc83fe54d8d45c43456d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ghedo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2nATXZnol5y7zCUtB31NWRhOApMmHkQV3pkk zncAUO3B/kFooSZZpHHSCGOPZR79Lz+gdImVjU0PzXC6OGIugtrE9IkPkeBFzp89InJRjovFWD7Cjk j9kvco+O4bIB5sGAFa6+tZwXFpgMK7sXI7NQHaIkKWDzfH/2jsXOYutAcbjGOELq4uZUU9Hc05/xgg w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/sx1I9lr-2VwCsK2kb_-IdLJnHB4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2019 18:28:30 -0000

ghedo commented on this pull request.



>  HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either
 unidirectional stream type MUST be treated as a connection error of type
 HTTP_CLOSED_CRITICAL_STREAM.
 
+An endpoint MAY avoid creating its own encoder stream if the maximum size of
+the dynamic table permitted by the peer is zero.
+
+An endpoint MAY avoid creating its own decoder stream if the maximum size of
+its own dynamic table is zero.
+
+An endpoint MUST allow its peer to create both encoder and decoder streams

Hmmm, I think I was reading https://github.com/quicwg/base-drafts/issues/2100#issuecomment-459241694 wrong.

But yeah, the intention there was to disallow setting the uni streams limit to less than 3 in order to allow the other side to open all of their streams. This is effectively what the spec says right now I think, since each side MUST create their streams and if the peer's limits prevent that, than the endpoint can't create them.

I would also be fine aloowing one side to prevent the other from opening and making that not an error, but either way I think we should specifiy what to do since the spec right now is far from clear on this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2529#discussion_r267485730