[quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME for something simpler (#2551)

Lucas Pardue <notifications@github.com> Mon, 25 March 2019 16:50 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 9CC60120446 for <quic-issues@ietfa.amsl.com>; Mon, 25 Mar 2019 09:50:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id eKEUeSy-Icap for <quic-issues@ietfa.amsl.com>; Mon, 25 Mar 2019 09:50:38 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com []) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB4D0120485 for <quic-issues@ietf.org>; Mon, 25 Mar 2019 09:50:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=uddiQ1PGHzi0SiTp+bC7ANtmOpI=; b=MK8MZ3alRr+R6RSk Ym1iSCWeZL4C5swT0xjQU6ZHNzAi9eSf3wzqmnx4dzFRIawouTZckVRlB2sa3OJX rX9T6ugFaDdQrbKpFEevo8tjjYgVZfABT0R9H7cpFztHAiQt+yO1Dy0lMb3fEfyz viTS97Ciaf/RlMbWfmkubuvz+LE=
Received: by filter0060p1iad2.sendgrid.net with SMTP id filter0060p1iad2-14336-5C9906DC-E 2019-03-25 16:50:36.396168791 +0000 UTC m=+860265.631854912
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown []) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id 8OoIcmJcRqC4ItS3kJPbCw for <quic-issues@ietf.org>; Mon, 25 Mar 2019 16:50:36.177 +0000 (UTC)
Received: from github.com (localhost []) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 295798005D for <quic-issues@ietf.org>; Mon, 25 Mar 2019 09:50:36 -0700 (PDT)
Date: Mon, 25 Mar 2019 16:50:36 +0000
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0e7c255d34ffa4f8e3e65fc0a5ad7703449354cb92cf0000000118b0c8dc92a169ce19551e35@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2551@github.com>
Subject: [quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME for something simpler (#2551)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c9906dc27e83_2d233faef1ed45c45342a3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1ouOV8X4GJ4fHcTN0hZWdmySpfr3Wf0rx94M +j/yBVP4q23muZpym0YMNwBWp+R78+5eLREKbitpNupxnHvsfjYnJzMxZjmS7AuDNfMxcVPuC9dmhP ngh5SUoYOnA/JAPMxx/Bo7DrY3L0pB7Lxpf29k47OSIbLzi2kOtTI6dHElm15Phz6mWTj2Bn89U/9h I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/t6wCBxzxadV_t6ZPu2aLl7ASqvw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Mar 2019 16:50:43 -0000

I remain unconvinced on the usefulness of the HTTP_MALFORMED_FRAME error code.

Draft 19 says:

>    the HTTP_MALFORMED_FRAME (0x01XX):  An error in a specific frame type.
      If the frame type is "0xfe" or less, the type is included as the
      last byte of the error code.  For example, an error in a 
      MAX_PUSH_ID frame would be indicated with the code (0x10D).  The
      last byte "0xff" is used to indicate any frame type greater than

At the core of my perspective is that the document currently mixes the use of this error between truncated frames and more-semantic-level errors eg. 
  * receiving a MAX_PUSH_ID with a value lower than a previously sent value.
  * PRIORITY (a super complicated frame)
  * SETTINGS (error with duplicate parameters). 

I'm not convinced these semantic errors are due to the frame being malformed, it is more 'misused'. Levelling up, I wonder if this error code is the best way of approaching the problems or if we could do something simpler. HTTP/2 had a HTTP_FRAME_SIZE error which was replaced by HTTP_MALFORMED_FRAME.

Another wrinke is: What should an endpoint do if it receives an error that references an unknown frame type? An endpoint MUST ignore unknown types, and we have these in the form of grease frame types with values that are included in the error code space.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: