Re: [quicwg/base-drafts] Rework section on persistent congestion (#3961)

Jana Iyengar <notifications@github.com> Wed, 29 July 2020 19:26 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C64C63A0E43 for <quic-issues@ietfa.amsl.com>; Wed, 29 Jul 2020 12:26:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9AuCI5bBR0lS for <quic-issues@ietfa.amsl.com>; Wed, 29 Jul 2020 12:26:37 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 73F1A3A0E3C for <quic-issues@ietf.org>; Wed, 29 Jul 2020 12:26:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=/kwLxq80CTh2VcB8aYi/dUFDMUXiN0lrkBgTEUXqMBo=; b= H8OHfMkrFrl0urew3aWv2mXjJc6LmGUfKOYflot2drF6uPfGmd3MdprauoNcmGj9 43uXsyZQYjffMT6gzK6sNJh4TU3mYdGI0uALdgc8cjLTeETHDgM5Lw9Kghi1O8dX jxHPRujC29BGjmG1lsH6Y4ogPw4Cb3zeN9cNI0DN8bI=
Received: by filter1680p1mdw1.sendgrid.net with SMTP id filter1680p1mdw1-878-5F21CD6C-29 2020-07-29 19:26:36.638915036 +0000 UTC m=+661.474059211
Received: from github-lowworker-52827f8.ash1-iad.github.net (unknown) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id xdD4FDcTTbSxh9oC0PTLig for <quic-issues@ietf.org>; Wed, 29 Jul 2020 19:26:36.606 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-52827f8.ash1-iad.github.net (Postfix) with ESMTP id 83EE45C0995 for <quic-issues@ietf.org>; Wed, 29 Jul 2020 12:26:36 -0700 (PDT)
Date: Wed, 29 Jul 2020 19:26:36 +0000
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ZE7CDIYZUV62TO555FWXGZEVBNHHCPPLSJE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3961/review/457822062@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3961@github.com>
References: <quicwg/base-drafts/pull/3961@github.com>
Subject: Re: [quicwg/base-drafts] Rework section on persistent congestion (#3961)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f21cd6c82886_ce216f81049ab"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak33HD/CKt9jS5oy/o0tuRO8Zx21UalHkb4zlY c2C51rZEV53nJwm7t1TEFiz1fdA2EU7xdFonsjLGJghUedziFxcwLwTmF6aRAUz+WZyCwg82uQrPWd C/H91Hbc0r8aac/nVT31aMBc8/5eZbb4l+DmtwuDsTWwGEkXWIHcjAZdopVqiIi7ZIisFDffNx5gFM 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tM40Fz1sK-rqwZlu3dgtoibP0gI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2020 19:26:40 -0000

@janaiyengar commented on this pull request.



> +
+This design does not use consecutive PTO events to establish persistent
+congestion, since a PTO expiration is controlled by application patterns in
+addition to network activity. For example, a sender that sends small amounts of
+data with silence periods between them restarts the PTO timer every time it
+sends, potentially preventing the PTO timer from expiring for a long period of
+time, even when no acknowledgments are being received. The use of a duration
+enables a sender to establish persistent congestion without depending on the
+occurrence of PTOs.
+
+### Establishing Persistent Congestion
+
+A sender establishes persistent congestion on receiving an acknowledgement, if
+the following conditions are true:
+
+* a prior RTT sample exists;

You're right -- but this was not resolved correctly. I've changed the language now to match what's in the draft as you proposed, and I've filed #3972.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3961#discussion_r462534577