Re: [quicwg/base-drafts] Fixing recovery pseudocode (#3909)

[Junho Choi <[e-mail]>]

> The following code makes sense to me at this moment:
> 
> ```
>    OnPacketsAcked(acked_packets):
>      for (packet in acked_packets):
>        // Remove from bytes_in_flight.
>        bytes_in_flight -= packet.sent_bytes
> 
>      // Do not increase congestion_window if application
>      // limited or flow control limited.
>      if (IsAppOrFlowControlLimited())
>        return
> 
>      for (packet in acked_packets):
>        if (InCongestionRecovery(packet.time_sent)):
>          // Do not increase congestion window in recovery period.
>          continue
>        if (congestion_window < ssthresh):
>          // Slow start.
>          congestion_window += packet.sent_bytes
>        else:
>          // Congestion avoidance.
>          congestion_window += max_datagram_size * acked_packet.sent_bytes
>            / congestion_window
> ```

Oh I see. When I implemented congestion control I used older version of the code.
I think we can simplify as follows:

```
OnPacketsAcked(acked_packets):
    for (packet in acked_packets):
        OnPacketAcked(packet)

OnPacketAcked(packet):
    // Remove from bytes_in_flight.
    bytes_in_flight -= packet.sent_bytes

    // Do not increase congestion_window if application
    // limited or flow control limited.
    if (IsAppOrFlowControlLimited())
        return

    // Do not increase congestion window in recovery period.
    if (InCongestionRecovery(packet.time_sent)):
        return

    if (congestion_window < ssthresh):
        // Slow start.
        congestion_window += packet.sent_bytes
    else:
        // Congestion avoidance.
        congestion_window += max_datagram_size * acked_packet.sent_bytes
            / congestion_window
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3909#issuecomment-658553570