IETF Logo Mail Archive

Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)

ekr <notifications@github.com> Wed, 01 August 2018 02:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D9C84130F1F for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 19:42:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.109
X-Spam-Level:
X-Spam-Status: No, score=-6.109 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hUqKKBbdlgiX for <quic-issues@ietfa.amsl.com>; Tue, 31 Jul 2018 19:42:01 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71734130E23 for <quic-issues@ietf.org>; Tue, 31 Jul 2018 19:42:01 -0700 (PDT)
Date: Tue, 31 Jul 2018 19:42:00 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533091321; bh=yvAvjuDOUkZ1Hfb/nERpfhYp9P6RSg1bw+qsiUK35GU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XG1ubI534xqSv49jf4SQklfiLMKq3Ex3hmK43QfO03rNGxTFsMLUmf+56TBn1S4qz Ecy84UJflNxnqj+evepxkMP+AFliqaEz+KBzrJ6k1QSojxR2ijK3qGm5XyKu9nShuL u/z6CNBctX1KH5IlHLefd7l7BsOtqCTNMu647hxU=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab34e1394013396e57c2b3b0f6427c20fc61c0fc6f92cf000000011778dff892a169ce149fd7cc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1612/409430942@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1612@github.com>
References: <quicwg/base-drafts/issues/1612@github.com>
Subject: Re: [quicwg/base-drafts] are flow control frames really idempotent? (#1612)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b611df8d4419_620d3fe5e7ed45c43625a1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tSPBgPxRjxDoyH2x-9eYQgMJZbs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2018 02:42:03 -0000

I'm not sure @siyengar is in the minority here. This seems like a pretty
easy implementation error to make, and the check he proposes would allow
you to detect it in practice. It's not really clear to me what the
significant optimization is that relaxing this enables.

On Tue, Jul 31, 2018 at 7:30 PM, Subodh Iyengar <notifications@github.com>
wrote:

> While I'm not a huge fan of this change, it looks like I'm in the minority
> here, so it's fine with me.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/quicwg/base-drafts/issues/1612#issuecomment-409428946>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABD1oeDLKluYmVqJ0iPL_ff7M8iwEL8xks5uMRK4gaJpZM4VniAh>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1612#issuecomment-409430942

v2.30.2 | Report a Bug | By Email | System Status