Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)

martinduke <notifications@github.com> Thu, 20 February 2020 23:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2BC31202DD for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 15:45:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pCYvtXnIurON for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 15:45:01 -0800 (PST)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DBD7F120289 for <quic-issues@ietf.org>; Thu, 20 Feb 2020 15:45:01 -0800 (PST)
Date: Thu, 20 Feb 2020 15:45:01 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582242301; bh=SiHwgvtgf5nIkuWgmTYINJn85te8H35EfMiwqT0EFtk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rDEMPIVCBZYoG/QjYg+pAuDqe9JTjLr8GHAJXI6Kt8SwFVlMb19KxBQkyKNN6o0Mf eEC9FtmtYmqV2LC0RqJ2jPjhJY9doXsP1eZbD2R1HE+12ZiC5gamo3s9aDZ03LuLU6 bXEJTbOpKTiYcqdWVU1C+FuMjdTbom/LThiOyGaE=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7WXQ7ULQUPWM6XO7N4LRGH3EVBNHHCDZCX6I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3473/review/362315289@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3473@github.com>
References: <quicwg/base-drafts/pull/3473@github.com>
Subject: Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4f19fd34c8f_75103fe2f16cd964866bb"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tSl_yRYXhyTsjMDH0yPaIsv_dR8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Feb 2020 23:45:04 -0000

martinduke commented on this pull request.



> @@ -4584,13 +4584,14 @@ stateless_reset_token (0x0002):
   reset ({{stateless-reset}}) for the connection ID negotiated during the
   handshake.
 
-max_packet_size (0x0003):
+max_udp_size (0x0003):

I like short names but if this in the consensus I'll change it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3473#discussion_r382322665