[quicwg/base-drafts] Remember UDP size limit for 0-RTT (#3498)

Martin Thomson <notifications@github.com> Wed, 04 March 2020 03:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 033F53A0D09 for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 19:44:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YiACW1Qe0Vur for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 19:44:06 -0800 (PST)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5E4713A0D08 for <quic-issues@ietf.org>; Tue, 3 Mar 2020 19:44:06 -0800 (PST)
Date: Tue, 03 Mar 2020 19:44:05 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583293445; bh=4ejQz5mYrGa4QY63c+VKMEM+0QTeWQd1EFFxPJUojMA=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=nu5lfhezhSTmL9oGkW7B06wzCy4Ow4S7jKd5iLlOZql5kFtI8hD74CH04n2pnXD/1 f05/Ab77JuSycNJsYX+uW215J+GrRrcMyij4DuQRBmNIHxX4rFgxwSBZXxsoHxjqbs KeYhRvgqisK9i69QYtxBT71IId9QbWhTXssGIsVE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3A5HFQH2TL6ZEZRS54NMCQLEVBNHHCER4U6A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3498@github.com>
Subject: [quicwg/base-drafts] Remember UDP size limit for 0-RTT (#3498)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e5f24058d429_192e3fe0146cd96c3518e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tVyrCHSRud78PuuSwM81ugLm5eM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2020 03:44:08 -0000

As @kazuho points out, isn&#39;t *necessary* for the server to remember and not reduce `max_udp_datagram_size`.  The connection doesn&#39;t fail if the value is reduced.  If the value is reduced below what the client assumes the path MTU to be (a client might remember this too), then it results in dropping all 0-RTT packets at the server.  That isn&#39;t fatal, but it is pretty terrible.

This says remember it, consistent with the preceding text.

Closes #3447.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3498

-- Commit Summary --

  * renamed max_packet_size to max_udp_size
  * fixed typo
  * synced to latest, resolved conflict
  * erase merge artifact
  * delete whitespace
  * Resolved multiple review comments
  * Update draft-ietf-quic-transport.md
  * MT&#39;s suggestion and resolve conflict
  * Merge branch &#39;max_datagram&#39; of https://github.com/martinduke/base-drafts into max_datagram
  * Editorial: More concise intro text
  * Update draft-ietf-quic-recovery.md
  * Update draft-ietf-quic-recovery.md
  * Update draft-ietf-quic-recovery.md
  * Clarify client anti-amplification response
  * Update draft-ietf-quic-transport.md
  * Simplify
  * Update draft-ietf-quic-transport.md
  * Reworked Martin&#39;s suggestion
  * Martin&#39;s suggestion reworded
  * Clarify adaptive loss thresholds
  * Make congestion control more self-contained
  * Separate out initial and min congestion window
  * Remove tabs from recovery draft
  * Lint HTAB
  * Transport parameters can be declared unilaterally
  * ^^
  * Scope connection IDs to the current connection
  * Fix typo in transport draft changelog
  * Improve language on evictable entries. (#3131)
  * Fix typo in HTTP draft (#3482)
  * HTTP/3: Add RFC8446 reference for TLS 1.3. (#3483)
  * Jana&#39;s suggestions
  * Update draft-ietf-quic-transport.md
  * Update draft-ietf-quic-transport.md
  * Update draft-ietf-quic-transport.md
  * Update draft-ietf-quic-transport.md
  * Update draft-ietf-quic-transport.md
  * Update draft-ietf-quic-transport.md
  * Update draft-ietf-quic-transport.md
  * MT&#39;s comments and minimize text in the appendix
  * Update draft-ietf-quic-recovery.md
  * Update draft-ietf-quic-recovery.md
  * Normative language in cc section
  * Remember max_udp_payload_size for 0-RTT

-- File Changes --

    M .lint.py (5)
    M draft-ietf-quic-http.md (8)
    M draft-ietf-quic-qpack.md (20)
    M draft-ietf-quic-recovery.md (90)
    M draft-ietf-quic-transport.md (58)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/3498.patch
https://github.com/quicwg/base-drafts/pull/3498.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3498