Re: [quicwg/base-drafts] Changelog for -28 (#3668)

Lucas Pardue <notifications@github.com> Tue, 19 May 2020 19:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 63C963A0D7A for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 12:39:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I5wIjlkDzGwL for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 12:39:28 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 27DE23A0D78 for <quic-issues@ietf.org>; Tue, 19 May 2020 12:39:28 -0700 (PDT)
Received: from github-lowworker-d1d6e31.ash1-iad.github.net (github-lowworker-d1d6e31.ash1-iad.github.net [10.56.105.50]) by smtp.github.com (Postfix) with ESMTP id 19020E00A2 for <quic-issues@ietf.org>; Tue, 19 May 2020 12:39:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589917167; bh=eL5K510d6I2So7Po7fhk2D/tH0pE2l5VPCIwh3BPa80=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TWly7HHwF0IWzRepKEtV4UeTdTSeK80L/Z3bxlYa7hixrARko2b9QjeZ2Ev2B+6h7 AXQJC5+77acLqOxKONif/+SxWbg3mo8sSCREZwehMhiloL9tgORRGWc/mHBwSOpiZx GT1kRw24r8ZNcV7IbkM7FS39tcWmW25nWqd6H0lY=
Date: Tue, 19 May 2020 12:39:27 -0700
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2P3BVISNG7HPB264N42ALO7EVBNHHCJ7QHRQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3668/review/414763242@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3668@github.com>
References: <quicwg/base-drafts/pull/3668@github.com>
Subject: Re: [quicwg/base-drafts] Changelog for -28 (#3668)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec435ef9ad4_dd33f8bc20cd964815d0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tZg1h9kcfqME-R8HxL8wBFk3clc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 19:39:30 -0000

@LPardue approved this pull request.

Looks good. I know we typically only document design changes but FWIW the switch of the diagram formatting might catch some people off-guard.

> +- The entire payload of a datagram is used when counting bytes for
+  avoid amplification attacks (#3333, #3470)

is there a grammar nit in here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3668#pullrequestreview-414763242