IETF Logo Mail Archive

Re: [quicwg/base-drafts] Move Generating Acknowledgements to Transport (#2916)

ianswett <notifications@github.com> Wed, 11 September 2019 20:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 18094120227 for <quic-issues@ietfa.amsl.com>; Wed, 11 Sep 2019 13:21:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z1td8XwczxeH for <quic-issues@ietfa.amsl.com>; Wed, 11 Sep 2019 13:21:54 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C63281201CE for <quic-issues@ietf.org>; Wed, 11 Sep 2019 13:21:53 -0700 (PDT)
Date: Wed, 11 Sep 2019 13:21:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568233312; bh=D2RLttw4IgeBRbo6OmIKQEX8mKkSxSU+ay6HwWifGGY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yrIqDEYZpSjI89GVdA854cH2+RbSo4bw607N8nzJpj9DqDwG/1UGs5RfQC4bdA9QG oCm8BjT4g/Ju8SyEe8yq0XR0ckaIG8rY07VEyXF/73q5Rfqs86fmAbof6AKjRb2cbt P9L5+qrTaBxBljh5ptmyVteGJ7P2kgbdE2cledAQ=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYHGOAJNXGZ4X54MFF3Q2L7BEVBNHHBYD42OI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2916/review/287049551@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2916@github.com>
References: <quicwg/base-drafts/pull/2916@github.com>
Subject: Re: [quicwg/base-drafts] Move Generating Acknowledgements to Transport (#2916)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d795760ddc62_27de3f94dd4cd9641385e8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tj_jMz5ct8jFzLkip0i7q61X7cA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Sep 2019 20:21:55 -0000

ianswett commented on this pull request.

Thanks for the update Jana, LGTM.

I think we should open an issue for Nick's question.  I wonder if we should remove the text about sending an ACK per RTT entirely?  ie: what if the RTT is 1us?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2916#pullrequestreview-287049551

v2.23.0 | Report a Bug | By Email