Date: Wed, 19 Jun 2019 10:26:58 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZJBRT5RIN3YOAAYEN3C6ROFEVBNHHBWTCMKQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2814/review/251852413@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2814@github.com>
References: <quicwg/base-drafts/pull/2814@github.com>
Subject: Re: [quicwg/base-drafts] Rationalize HTTP_WRONG_SETTING_DIRECTION
 (#2814)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d0a7062b2d1d_614c3fa8baecd9646348aa";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tkIKDYmMEt54jv98Cwaxp3iTxYk>


----==_mimepart_5d0a7062b2d1d_614c3fa8baecd9646348aa
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

MikeBishop commented on this pull request.

Looks good!

> @@ -1595,9 +1595,10 @@ HTTP_NO_ERROR (0x00):
 : No error.  This is used when the connection or stream needs to be closed, but
   there is no error to signal.
 
-HTTP_WRONG_SETTING_DIRECTION (0x01):
-: A client-only setting was sent by a server, or a server-only setting by a
-  client.
+HTTP_SETTINGS_ERROR (0x01):
+: An endpoint detected an error with a SETTINGS frame: a duplicate setting was
+  detected, a client-only setting was sent by a server, or a server-only setting
+  by a client.

The suggestion to move HTTP_GENERAL_PROTOCOL_ERROR to 0x01 might be worth taking at the same time, since people are going to change which error to use for these anyway.  (Also, I just noticed that GPE is missing from the IANA table.)

> @@ -1902,7 +1903,7 @@ The entries in the following table are registered by this document.
 | Name                                | Code       | Description                              | Specification          |
 | ----------------------------------- | ---------- | ---------------------------------------- | ---------------------- |
 | HTTP_NO_ERROR                       | 0x0000     | No error                                 | {{http-error-codes}}   |
-| HTTP_WRONG_SETTING_DIRECTION        | 0x0001     | Setting sent in wrong direction          | {{http-error-codes}}   |
+| HTTP_SETTINGS_ERROR                 | 0x0001     | Setting duplication or wrong direction   | {{http-error-codes}}   |

I'd be more general -- SETTINGS frame contained invalid values, or something like that.  It's anything that could go wrong with that frame's payload.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2814#pullrequestreview-251852413
----==_mimepart_5d0a7062b2d1d_614c3fa8baecd9646348aa
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@MikeBishop</b> commented on this pull request.</p>

<p>Looks good!</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2814#discussion_r295416167">draft-ietf-quic-http.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1595,9 +1595,10 @@ HTTP_NO_ERROR (0x00):
 : No error.  This is used when the connection or stream needs to be closed, but
   there is no error to signal.
 
-HTTP_WRONG_SETTING_DIRECTION (0x01):
-: A client-only setting was sent by a server, or a server-only setting by a
-  client.
+HTTP_SETTINGS_ERROR (0x01):
+: An endpoint detected an error with a SETTINGS frame: a duplicate setting was
+  detected, a client-only setting was sent by a server, or a server-only setting
+  by a client.
</pre>
<p>The suggestion to move HTTP_GENERAL_PROTOCOL_ERROR to 0x01 might be worth taking at the same time, since people are going to change which error to use for these anyway.  (Also, I just noticed that GPE is missing from the IANA table.)</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2814#discussion_r295416660">draft-ietf-quic-http.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1902,7 +1903,7 @@ The entries in the following table are registered by this document.
 | Name                                | Code       | Description                              | Specification          |
 | ----------------------------------- | ---------- | ---------------------------------------- | ---------------------- |
 | HTTP_NO_ERROR                       | 0x0000     | No error                                 | {{http-error-codes}}   |
-| HTTP_WRONG_SETTING_DIRECTION        | 0x0001     | Setting sent in wrong direction          | {{http-error-codes}}   |
+| HTTP_SETTINGS_ERROR                 | 0x0001     | Setting duplication or wrong direction   | {{http-error-codes}}   |
</pre>
<p>I'd be more general -- SETTINGS frame contained invalid values, or something like that.  It's anything that could go wrong with that frame's payload.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2814?email_source=notifications&amp;email_token=AFTOJKYAF4BVKBS5KSTFHMDP3JT6FA5CNFSM4HZJC77KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4BPM7I#pullrequestreview-251852413">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKYQRBSKKLEEW6V3FS3P3JT6FANCNFSM4HZJC77A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK6TUTDMNJPPI6UPTJ3P3JT6FA5CNFSM4HZJC77KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4BPM7I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2814?email_source=notifications\u0026email_token=AFTOJKYAF4BVKBS5KSTFHMDP3JT6FA5CNFSM4HZJC77KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4BPM7I#pullrequestreview-251852413",
"url": "https://github.com/quicwg/base-drafts/pull/2814?email_source=notifications\u0026email_token=AFTOJKYAF4BVKBS5KSTFHMDP3JT6FA5CNFSM4HZJC77KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4BPM7I#pullrequestreview-251852413",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5d0a7062b2d1d_614c3fa8baecd9646348aa--