IETF Logo Mail Archive

Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)

Marten Seemann <notifications@github.com> Thu, 07 February 2019 15:24 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6FCCF124C04 for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 07:24:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.374
X-Spam-Level:
X-Spam-Status: No, score=-0.374 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vY5F9kLm3YLa for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 07:24:14 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4FC0F12008F for <quic-issues@ietf.org>; Thu, 7 Feb 2019 07:24:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=rtAPn9ORMNP7bEz4WKgTFQyFPyM=; b=Bo2s0nV+lDcYsbRB i83gM1NH8mfQOMgu6exbhkTVbZJI15Sw5Jt4lQpbyKBR2KF/DT6phKTYuOekz9/u 79o8ncIS0cK0TxgQS8b8G2oG3Sf6skpZ9oJddYdIwEFUSJDY5Xz0lDBLoCS5qKxs qL3RQ5GWrB5E2P7hW3+htOYIkJA=
Received: by filter0700p1las1.sendgrid.net with SMTP id filter0700p1las1-15304-5C5C4D9D-20 2019-02-07 15:24:13.845504103 +0000 UTC m=+156225.501775923
Received: from github-lowworker-39ccb07.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0035p1iad2.sendgrid.net (SG) with ESMTP id 9OGCf9KNQh2ItdJIJNVGXg for <quic-issues@ietf.org>; Thu, 07 Feb 2019 15:24:13.732 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-39ccb07.cp1-iad.github.net (Postfix) with ESMTP id B0BF6400EB8 for <quic-issues@ietf.org>; Thu, 7 Feb 2019 07:24:13 -0800 (PST)
Date: Thu, 07 Feb 2019 15:24:13 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba0ca3f3d277f3c68048791348f41db9d7361feae92cf0000000118740f9d92a169ce183c6fbc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2417/review/201145903@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2417@github.com>
References: <quicwg/base-drafts/pull/2417@github.com>
Subject: Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5c4d9dae710_7fe83ffcdb2d45c0226017"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0ME5YYnCvdDHZMr2piPu8aqNjH5yy1bBPxE2 5oA3rvTEgNyIO4B8rblQpgC85q9X2IHCEPng4D0LvB6pJAgHi33OYC0uI9ce3ZJtFqANBPtrlMSuJs aSUGJN26gTNHM4LmH6bqgfF+oeepDoOXNWMQt4YQs5vGBSooA7GPP82Vzsc8IUMTiBURzxnJTI3vlx k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/tpCa8vLTFgZWsTLUp7hJq_jgzkk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 15:24:15 -0000

marten-seemann commented on this pull request.



> @@ -819,6 +819,16 @@ kGranularity:
 kInitialRtt:
 : The RTT used before an RTT sample is taken. The RECOMMENDED value is 100ms.
 
+kPacketNumberSpace:
+: An enum to enumerate the three packet number spaces.
+~~~
+  enum kPacketNumberSpace {
+    Initial,
+    Handshake,
+    Application data,

Python enums don't look particularly nice though: https://docs.python.org/3/library/enum.html#creating-an-enum

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2417#discussion_r254728416

v2.14.0 | Report a Bug | By Email