Re: [quicwg/base-drafts] http-core and Friends (#3513)

Mark Nottingham <notifications@github.com> Mon, 16 March 2020 02:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 879B23A0779 for <quic-issues@ietfa.amsl.com>; Sun, 15 Mar 2020 19:00:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cms_zEOjlIJC for <quic-issues@ietfa.amsl.com>; Sun, 15 Mar 2020 19:00:46 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5472D3A0778 for <quic-issues@ietf.org>; Sun, 15 Mar 2020 19:00:46 -0700 (PDT)
Date: Sun, 15 Mar 2020 19:00:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584324045; bh=mGlTA5T/lJX3szlP7zSzZqybhBrUZpr7ZrIYg9RhV3o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=f2pA2e/aq6a/yNVWEmHmXfNVaBB+oc5EgP2ZKzYIhcfrGnzSpi/Az+4LCzIVOyXmc u/F1fnf3I8CibJJeIcM6Pqs13aCNTNT6oVEBbodhXcCf2tflOtM+eejddkXex2XPYT v2obnba1xap1+R4hSCm+qYcCIx7I+Bz0sQH2eZuo=
From: Mark Nottingham <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2EHJCZROABGI4R3TV4PK7M3EVBNHHCFCTWBI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3513/review/374875589@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3513@github.com>
References: <quicwg/base-drafts/pull/3513@github.com>
Subject: Re: [quicwg/base-drafts] http-core and Friends (#3513)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6eddcd4cbc2_1cbf3f89cbccd960175357"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mnot
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uDcmKY_GwaWR_98EB7xzx0MlmJI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Mar 2020 02:00:48 -0000

mnot commented on this pull request.



> @@ -809,7 +810,7 @@ using the same format described for responses in {{request-response}}.
 Due to reordering, push stream data can arrive before the corresponding
 PUSH_PROMISE frame.  When a client receives a new push stream with an
 as-yet-unknown Push ID, both the associated client request and the pushed
-request fields are unknown.  The client can buffer the stream data in
+request headerss are unknown.  The client can buffer the stream data in

```suggestion
request header fields are unknown.  The client can buffer the stream data in
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3513#pullrequestreview-374875589