IETF Logo Mail Archive

Re: [quicwg/base-drafts] Suggestion for #2499 (#2503)

ianswett <notifications@github.com> Fri, 08 March 2019 14:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD8F01279AD for <quic-issues@ietfa.amsl.com>; Fri, 8 Mar 2019 06:53:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vw06ZgUlc6I8 for <quic-issues@ietfa.amsl.com>; Fri, 8 Mar 2019 06:53:54 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 70672131399 for <quic-issues@ietf.org>; Fri, 8 Mar 2019 06:53:54 -0800 (PST)
Date: Fri, 08 Mar 2019 06:53:52 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552056832; bh=Iana7E4Jb5aGQKF7I0WBPODpXBFKEWGwRDD6y+3kdlg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yZZd7eHhjIf4p5J8HrZkagCpFiWA2TeMGkmPEE0gT5x/PBj9GlPrRD/viEQLStsDI In1giTj0RXKnuL6up3CE/STaJfIQm7RoZ5Fk2rrZWC7PyOninYsd/7VWUQvYIK1iqu Z5xN6YDTS5wpEsCgo58YvZwZ3lDnB4BKmsaIppKI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1817bf9f8eb22acd3c6d08e357ada49370010a7092cf00000001189a440092a169ce18f33db6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2503/review/212316158@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2503@github.com>
References: <quicwg/base-drafts/pull/2503@github.com>
Subject: Re: [quicwg/base-drafts] Suggestion for #2499 (#2503)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c828200c7724_2eb23f86f18d45c02599e4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uFvPqCisOC_xUdLFeoKOUqOFPF8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Mar 2019 14:54:03 -0000

ianswett commented on this pull request.

One suggestion, but looks good overall.

> @@ -269,9 +269,10 @@ data in one direction: from the initiator of the stream to its peer.
 Bidirectional streams allow for data to be sent in both directions.
 
 Streams are identified within a connection by a numeric value, referred to as
-the stream ID.  Stream IDs are unique to a stream. A QUIC endpoint MUST NOT
-reuse a stream ID within a connection.  Stream IDs are encoded as
-variable-length integers (see {{integer-encoding}}).
+the stream ID.  A stream ID is a 62-bit integer (0 to 2^62-1) that is unique for
+all streams on a connection. A QUIC endpoint MUST NOT reuse a stream ID within a
+connection.  Stream IDs are encoded as variable-length integers (see

I'd put this sentence up one, so it's next to the 62 bit integer sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2503#pullrequestreview-212316158

v2.23.0 | Report a Bug | By Email