Re: [quicwg/base-drafts] Clarify section on negotiating connection IDs (#3349)

Martin Thomson <notifications@github.com> Tue, 04 February 2020 13:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E6EE1200C4 for <quic-issues@ietfa.amsl.com>; Tue, 4 Feb 2020 05:46:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kb5LAUaXhXYG for <quic-issues@ietfa.amsl.com>; Tue, 4 Feb 2020 05:46:40 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CFC83120020 for <quic-issues@ietf.org>; Tue, 4 Feb 2020 05:46:39 -0800 (PST)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id 1E8172C2205 for <quic-issues@ietf.org>; Tue, 4 Feb 2020 05:46:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580823999; bh=tfR0x/VybLG0rNmK45ywOYksrtgNRG4gL50TyMgJYVM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XwP12yNFR9KiO4NCTBdPnr73w6niFKvXNS7pnLwsE785MjAEe03ltVBv4voUhZq0l nk0NOjBmvtOE664XMWzueQ69tLPurJ93qVa1MmwXEvGbEcVWFmEA2EIkTp/YLPjcb6 tTff6/PLgdc+WBC1yrClEjehE4hN0RMe6CHHj8js=
Date: Tue, 04 Feb 2020 05:46:39 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2ASEBRWVXBPXXZLH54I2UD7EVBNHHCBTP6UY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3349/review/352982771@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3349@github.com>
References: <quicwg/base-drafts/pull/3349@github.com>
Subject: Re: [quicwg/base-drafts] Clarify section on negotiating connection IDs (#3349)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e3975bf16b75_e2f3fa6ccccd96029884"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uFyLS2DF5-07faqsz0gbDyHpXOA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2020 13:46:41 -0000

martinthomson commented on this pull request.



> -Initial); a server MUST set its value based on the Initial packet.  Any
-additional changes are not permitted; if subsequent packets of those types
-include a different Source Connection ID, they MUST be discarded.  This avoids
-problems that might arise from stateless processing of multiple Initial packets
-producing different connection IDs.
-
-The connection ID can change over the lifetime of a connection, especially in
-response to connection migration ({{migration}}); see {{issue-cid}} for details.
+the SCID supplied by the server as the DCID for subsequent packets, including
+all subsequent 0-RTT packets. This means that a client might change the DCID
+twice during connection establishment, once in response to a Retry and once in
+response to an Initial packet from the server. Once a client has received an
+Initial packet from the server, it MUST discard any subsequent packet it
+receives with a different Source Connection ID.
+
+A client MUST change the DCID value it sends in response to only the first

```suggestion
A client MUST change the Destination Connection ID value it uses for sending packets in response to only the first
```

> -additional changes are not permitted; if subsequent packets of those types
-include a different Source Connection ID, they MUST be discarded.  This avoids
-problems that might arise from stateless processing of multiple Initial packets
-producing different connection IDs.
-
-The connection ID can change over the lifetime of a connection, especially in
-response to connection migration ({{migration}}); see {{issue-cid}} for details.
+the SCID supplied by the server as the DCID for subsequent packets, including
+all subsequent 0-RTT packets. This means that a client might change the DCID
+twice during connection establishment, once in response to a Retry and once in
+response to an Initial packet from the server. Once a client has received an
+Initial packet from the server, it MUST discard any subsequent packet it
+receives with a different Source Connection ID.
+
+A client MUST change the DCID value it sends in response to only the first
+received Initial or Retry packet.  A server MUST set its DCID value based on the

```suggestion
received Initial or Retry packet.  A server MUST set the Destination Connection ID it uses for sending packets based on the
```

> -problems that might arise from stateless processing of multiple Initial packets
-producing different connection IDs.
-
-The connection ID can change over the lifetime of a connection, especially in
-response to connection migration ({{migration}}); see {{issue-cid}} for details.
+the SCID supplied by the server as the DCID for subsequent packets, including
+all subsequent 0-RTT packets. This means that a client might change the DCID
+twice during connection establishment, once in response to a Retry and once in
+response to an Initial packet from the server. Once a client has received an
+Initial packet from the server, it MUST discard any subsequent packet it
+receives with a different Source Connection ID.
+
+A client MUST change the DCID value it sends in response to only the first
+received Initial or Retry packet.  A server MUST set its DCID value based on the
+first received Initial packet. Any further changes to the DCID are not
+permitted; if subsequent Initial packets include a different SCID, they MUST be

are only permitted if the values are taken from NEW_CONNECTION_ID frames; if subsequent

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3349#pullrequestreview-352982771