IETF Logo Mail Archive

Re: [quicwg/base-drafts] Recovery: Execute the previously unarmed PTO to avoid a deadlock (#4830)

Nick Banks <notifications@github.com> Tue, 23 February 2021 16:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5964E3A089C for <quic-issues@ietfa.amsl.com>; Tue, 23 Feb 2021 08:23:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.124
X-Spam-Level:
X-Spam-Status: No, score=-2.124 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y4qs1YHIpuh0 for <quic-issues@ietfa.amsl.com>; Tue, 23 Feb 2021 08:22:59 -0800 (PST)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 226E63A0887 for <quic-issues@ietf.org>; Tue, 23 Feb 2021 08:22:59 -0800 (PST)
Received: from github.com (hubbernetes-node-4c0e459.ash1-iad.github.net [10.56.121.19]) by smtp.github.com (Postfix) with ESMTPA id 56C858407FB for <quic-issues@ietf.org>; Tue, 23 Feb 2021 08:22:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1614097378; bh=QaZku4DcZ7lbqvvfa+uHuAVtlePr3lUIRpbcn9jfO4w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=m1LZlr5kjP1x/tPHWdMUHipguTK58n3iYedTNBtj0q8E7hwaMc0QywTwqoMaBr+TN UNeoEhH2sVWZOAKL88os7Iln7umzlanYHqW/sTo/1HJpjv51/x+Ww5wZSf6Jdn59rf Lipb6RD+dpD5QmMgfDEo2nYMmO2SMFZVzOAF698c=
Date: Tue, 23 Feb 2021 08:22:58 -0800
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK26QGAKEVDLOSDZJB56IEGOFEVBNHHDBDOMD4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4830/784323998@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4830@github.com>
References: <quicwg/base-drafts/issues/4830@github.com>
Subject: Re: [quicwg/base-drafts] Recovery: Execute the previously unarmed PTO to avoid a deadlock (#4830)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_60352be25404d_501a54162815"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uJ96OAK5JuiX-sCZC3CTJLFP2Q8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2021 16:23:00 -0000

I went and double checked the msquic code [here](https://github.com/microsoft/msquic/blob/v1.0.0-129524/src/core/path.c#L96), and we always re-enable the loss detection timer when we become "unblocked" by amplification protection logic. I thought this logic was already driven by some statement in the spec.

I just went back and found this:

> A.6.  On Receiving a Datagram
> 
>    When a server is blocked by anti-amplification limits, receiving a
>    datagram unblocks it, even if none of the packets in the datagram are
>    successfully processed.  In such a case, the PTO timer will need to
>    be re-armed.

Do we need any more than this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/4830#issuecomment-784323998

v2.23.0 | Report a Bug | By Email