Re: [quicwg/base-drafts] Remove indent from all pseudocode (#4012)

[ianswett <[e-mail]>]

@ianswett approved this pull request.

LG, but I want to leave some of the empty lines.

> -
-    // Do not increase congestion window in recovery period.
-    if (InCongestionRecovery(acked_packet.time_sent)):
-      return
-
-    if (congestion_window < ssthresh):
-      // Slow start.
-      congestion_window += acked_packet.sent_bytes
-    else:
-      // Congestion avoidance.
-      congestion_window +=
-        max_datagram_size * acked_packet.sent_bytes
-        / congestion_window
+InCongestionRecovery(sent_time):
+  return sent_time <= congestion_recovery_start_time
+OnPacketsAcked(acked_packets):

These are different methods, so I'd like to keep a blank line between them.
```suggestion

OnPacketsAcked(acked_packets):
```

> -      return
-
-    if (congestion_window < ssthresh):
-      // Slow start.
-      congestion_window += acked_packet.sent_bytes
-    else:
-      // Congestion avoidance.
-      congestion_window +=
-        max_datagram_size * acked_packet.sent_bytes
-        / congestion_window
+InCongestionRecovery(sent_time):
+  return sent_time <= congestion_recovery_start_time
+OnPacketsAcked(acked_packets):
+  for acked_packet in acked_packets:
+    OnPacketAcked(acked_packet)
+OnPacketAcked(acked_packet):

```suggestion

OnPacketAcked(acked_packet):
```

> -     // Collapse congestion window if persistent congestion
-     if (InPersistentCongestion(lost_packets.largest())):
-       congestion_window = kMinimumWindow
+InPersistentCongestion(largest_lost):
+  // Persistent congestion cannot be declared on the
+  // first RTT sample.
+  if (is first RTT sample):
+    return false
+  pto = smoothed_rtt + max(4 * rttvar, kGranularity) +
+    max_ack_delay
+  congestion_period = pto * kPersistentCongestionThreshold
+  // Determine if all packets in the time period before the
+  // largest newly lost packet, including the edges and
+  // across all packet number spaces, are marked lost.
+  return AreAllPacketsLost(largest_lost, congestion_period)
+OnPacketsLost(lost_packets):

```suggestion

OnPacketsLost(lost_packets):
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4012#pullrequestreview-469521930