Date: Wed, 23 Aug 2017 16:22:35 +0000 (UTC)
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abb297b786fae820b3ec5cc64ac7ef3783982705fd92cf0000000115b56dcb92a169ce0edf94fd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/721/review/58135543@github.com>
In-Reply-To: <quicwg/base-drafts/pull/721@github.com>
References: <quicwg/base-drafts/pull/721@github.com>
Subject: Re: [quicwg/base-drafts] Refactor the section on connection
 termination (#721)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_599dabcb180cc_c353fe91c33dc3c8342";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uKJ4nnOQsZFGJwV7fq2KKdTWKIM>

----==_mimepart_599dabcb180cc_c353fe91c33dc3c8342
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

MikeBishop commented on this pull request.



> @@ -1415,31 +1415,59 @@ TODO: see issue #161
 Connections should remain open until they become idle for a pre-negotiated
 period of time.  A QUIC connection, once established, can be terminated in one
 of four ways: negotiated shutdown, idle timeout, immediate close, and a

This list still refers to "negotiated shutdown" while the subsections refer to "application close."  Might want to align them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/721#pullrequestreview-58135543
----==_mimepart_599dabcb180cc_c353fe91c33dc3c8342
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@MikeBishop</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/721#discussion_r134800266">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1415,31 +1415,59 @@ TODO: see issue #161
 Connections should remain open until they become idle for a pre-negotiated
 period of time.  A QUIC connection, once established, can be terminated in one
 of four ways: negotiated shutdown, idle timeout, immediate close, and a
</pre>
<p>This list still refers to "negotiated shutdown" while the subsections refer to "application close."  Might want to align them.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/721#pullrequestreview-58135543">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq8U8DobPoFwRuMcIE2MqH7L-s0qIks5sbFHLgaJpZM4O0OWB">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AWbkq6X6eUGnVXvDKwwWukdOWRU9VnGEks5sbFHLgaJpZM4O0OWB.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/quicwg/base-drafts/pull/721#pullrequestreview-58135543"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MikeBishop commented on #721"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/721#pullrequestreview-58135543"}}}</script>
----==_mimepart_599dabcb180cc_c353fe91c33dc3c8342--