Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)

Kazuho Oku <notifications@github.com> Sun, 17 November 2019 07:43 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5D361200A3 for <quic-issues@ietfa.amsl.com>; Sat, 16 Nov 2019 23:43:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w3fNeGBw1DGA for <quic-issues@ietfa.amsl.com>; Sat, 16 Nov 2019 23:43:49 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3FF5B1200BA for <quic-issues@ietf.org>; Sat, 16 Nov 2019 23:43:49 -0800 (PST)
Date: Sat, 16 Nov 2019 23:43:48 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573976628; bh=0rtJXjWbLOyhKEZzzyiyyczPYEgkwqa7+tWDML6F7Ww=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OQ+HMG6MbX1noYcaOO3VvIU7Q2Ao8IJZf48cWkrCk7USbEn5r9mtXgJLtXr2JeAg/ LHomMhsfoJ/PK9a4jkW5Sz9bWiTnBB20PpFAdvs/5rotu3ZCWLJo5gMS+Bo6msECkj C+a7bdIKkdrBE83z2RDjn4LBHX8RaRoOwAks4XY4=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK34PJ6AGGCSNY2WCMV33YWLJEVBNHHB532IFY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3201/review/318005163@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3201@github.com>
References: <quicwg/base-drafts/pull/3201@github.com>
Subject: Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd0fa3475dcf_77f73f7edeecd96016694a4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uRjZUX1nlfoQC4XH4bQMpHtwLkA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 07:43:51 -0000

kazuho commented on this pull request.



> @@ -4590,8 +4595,11 @@ preferred_address (0x000d):
 active_connection_id_limit (0x000e):
 
 : The maximum number of connection IDs from the peer that an endpoint is willing
-  to store. This value includes only connection IDs sent in NEW_CONNECTION_ID
-  frames. If this parameter is absent, a default of 0 is assumed.
+  to store. This value includes connection IDs sent in NEW_CONNECTION_ID frames,
+  the connection ID used during the handshake as well as the connection ID
+  provided in the preferred_address transport parameter.
+  If the active_connection_id_limit parameter is absent, a default of 2 is
+  assumed. Values below 2 are invalid.

The default and minimal values of 2 look odd, when using a zero-length CID.

Maybe rephrase to:
> Unless a zero-length connection ID is being used, the value of the active_connection_id_limit parameter MUST be no less than 2. If the active_connection_id_limit parameter is absent, a default of 2 is
   assumed.
> 
> When a zero-length connection ID is being used, the active_connection_id_limit parameter MUST NOT be sent.

The rationale behind the last sentence is that it disputable if we consider CIDL=0 as the absence of CID or as the use of zero-length CID. The value of active_connection_id_limit becomes zero or one based on the view you choose. Hence my preference to require absence of the TP when a zero-length CID is used.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3201#pullrequestreview-318005163