Re: [quicwg/base-drafts] clarify the scope of a NEW_TOKEN token (#3156)
Kazuho Oku <notifications@github.com> Mon, 28 October 2019 12:03 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3A6EA12084C for <quic-issues@ietfa.amsl.com>; Mon, 28 Oct 2019 05:03:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qCrA3W35wNbP for <quic-issues@ietfa.amsl.com>; Mon, 28 Oct 2019 05:03:12 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19B3B12083C for <quic-issues@ietf.org>; Mon, 28 Oct 2019 05:03:12 -0700 (PDT)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id 4B1B15201AF for <quic-issues@ietf.org>; Mon, 28 Oct 2019 05:03:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572264191; bh=lpBaMQ2Zcvm7+6BFFh9slZSkXKnOIjaSVKdRM6tSEG8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lg83CkXtwAOS+0aKLl/zrV4L8+knFnEI3dgqrQgH/A2C95owyqCrnySzUiQ3uSLVS ZqNCAjVbaTQZT7GE4aEOprr66fagbRCRkQ/lZjNGcjYyfgGB9/6xqF/vVzchb4E48p jR+6E3iFFtViNBX4Q4i9X2HyQQj5oRJWdWAKLevI=
Date: Mon, 28 Oct 2019 05:03:11 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7OF4CSSGK7JKIXAIV3YQFX7EVBNHHB5FNSNM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3156/review/307799701@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3156@github.com>
References: <quicwg/base-drafts/pull/3156@github.com>
Subject: Re: [quicwg/base-drafts] clarify the scope of a NEW_TOKEN token (#3156)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db6d8ff3bc7a_70023fe1a26cd96492383"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uXbF_xJ8FLsCxmx6m5AxRt6PZzU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Oct 2019 12:03:19 -0000
kazuho commented on this pull request. > @@ -1698,10 +1698,14 @@ encrypted form in the token. It is unlikely that the client port number is the same on two different connections; validating the port is therefore unlikely to be successful. -If the client has a token received in a NEW_TOKEN frame on a previous connection -to what it believes to be the same server, it SHOULD include that value in the -Token field of its Initial packet. Including a token might allow the server to -validate the client address without an additional round trip. +A token received in a NEW_TOKEN frame is applicable against the servers that the +connection is considered authoritative for (e.g., server names included in the +certificate). A client MUST only use a token that is applicable to the server +that the client is connecting to to. If the client has a token received in a +NEW_TOKEN frame that is applicable to a new connection attempt, it SHOULD Thank you for the suggestion. I believe the intent here is to recommend the use of tokens when appropriate; hence went with e67d713. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3156#discussion_r339526766
- [quicwg/base-drafts] clarify the scope of a NEW_T… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Martin Thomson
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Martin Thomson
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Martin Thomson
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Jana Iyengar
- Re: [quicwg/base-drafts] clarify the scope of a N… MikkelFJ
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… MikkelFJ
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… MikkelFJ
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… MikkelFJ
- Re: [quicwg/base-drafts] clarify the scope of a N… ekr
- Re: [quicwg/base-drafts] clarify the scope of a N… MikkelFJ
- Re: [quicwg/base-drafts] clarify the scope of a N… Kazuho Oku
- Re: [quicwg/base-drafts] clarify the scope of a N… Martin Thomson