Re: [quicwg/base-drafts] Sequence for Connection IDs, RETIRE (#1829)

Mike Bishop <notifications@github.com> Wed, 03 October 2018 19:03 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 802EF128CFD for <quic-issues@ietfa.amsl.com>; Wed, 3 Oct 2018 12:03:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.999
X-Spam-Level:
X-Spam-Status: No, score=-2.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZF6KpDreIr5D for <quic-issues@ietfa.amsl.com>; Wed, 3 Oct 2018 12:03:30 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D870712D7EA for <quic-issues@ietf.org>; Wed, 3 Oct 2018 12:03:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=cDtx42ujFv2xLOnn9YMzgYg3yTc=; b=E/s4wn0VDGD/PL7v ITPKA9L9DnyTgWzGXgIOue1vfwyFRrDZuq7zWHOjWlNPs6cEZVKEJZRmchSApxDX WGb2UQqgVxzgAxdMXDolL262Ip+OLILZGH+jRPkU80J3Ap0Y1cOg0mcp2gE/63rH CNdrW0LzwHGUSywBsOfYJ0G9XKc=
Received: by filter1273p1mdw1.sendgrid.net with SMTP id filter1273p1mdw1-12631-5BB5127F-16 2018-10-03 19:03:27.279687904 +0000 UTC m=+694195.523290440
Received: from github-lowworker-05ceafd.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id yhCprfsMS5q3gufG5QYwDA for <quic-issues@ietf.org>; Wed, 03 Oct 2018 19:03:27.224 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-05ceafd.cp1-iad.github.net (Postfix) with ESMTP id 21E1A46015F for <quic-issues@ietf.org>; Wed, 3 Oct 2018 12:03:27 -0700 (PDT)
Date: Wed, 03 Oct 2018 19:03:27 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb93948a5cc9e65b419aa301b51874acf8922b83892cf0000000117ccd47f92a169ce15d2a9cb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1829/review/161314854@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1829@github.com>
References: <quicwg/base-drafts/pull/1829@github.com>
Subject: Re: [quicwg/base-drafts] Sequence for Connection IDs, RETIRE (#1829)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb5127f18d6a_41953fee354d45b463679e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1dfMM/0YnMVeoLGMMboei8nW1F+xk8H3Uq2X 2ksZdJPYvuXlHMazRWg8XwsHGY2UQxumj8TVXYNA4To79cr+R0XbrWptUwysg5wUblu+InxxWSPoQr YWOOMfpTJN7MmSAiyybi3GHEzlynowivncI/+EOnp3o6aIi3NrO0+DXEI2VfxDIPwoCwNXrSUCnPeG 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uZnqeWuYPdxFhTGH8SRhRVmrh1g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 19:03:33 -0000

MikeBishop commented on this pull request.



> @@ -1249,8 +1252,11 @@ using the NEW_CONNECTION_ID frame ({{frame-new-connection-id}}).
 ### Issuing Connection IDs
 
 The initial connection ID issued by an endpoint is the Source Connection ID
-during the handshake.  Subsequent connection IDs are communicated to the peer
-using NEW_CONNECTION_ID frames ({{frame-new-connection-id}}).
+during the handshake.  The sequence number of the initial connection ID is 0. If

We can avoid that if the entire CID is sent in the RETIRE_CID frame.  That would mean, instead, that issuers need to stop using the contained CID for the current connection iff they are and absorb duplicates by silently consuming RETIRE messages for CIDs which aren't associated with the connection.

By having the sequence number in the RETIRE_CID frame, we make it shorter (one varint) and enable using the same deduplicating code as the consumer of NEW_CID messages.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1829#discussion_r222430109