Re: [quicwg/base-drafts] Modify codepoints on decoder and request/push streams for consistency (#1472)

Mike Bishop <notifications@github.com> Fri, 22 June 2018 18:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 67F34130EED for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 11:50:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bxnS8vra2m8g for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 11:50:18 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BABDE130EC1 for <quic-issues@ietf.org>; Fri, 22 Jun 2018 11:50:18 -0700 (PDT)
Date: Fri, 22 Jun 2018 11:50:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529693418; bh=qL1yFgAUG8NyBaa2QQPcOYPeA6LHSQI3g4gLSuDeES0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yFkjrm1aO4zhRQ2d39KeoR8IAO7DktVH7LubIYtc5Tq84TBj6Kh+ffF9iYG3ffb9w 2QgXIw9NNs+6kOa6NSi0EEYYbMVISiDvv+MDyloIjJTbESgWhXAmLlWhKVXIl0SEb/ sAYm9u90NL6hGwBUXBtJMVs9j3XIpT2KFJZBCPS4=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6011b8853b23ea982a9d9c56fc3b48001f635a7892cf00000001174506ea92a169ce13f7628b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1472/review/131307888@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1472@github.com>
References: <quicwg/base-drafts/pull/1472@github.com>
Subject: Re: [quicwg/base-drafts] Modify codepoints on decoder and request/push streams for consistency (#1472)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b2d44ea29f26_4e573fd5d3eeef88110462"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ueE5dKbw2tSA02z-wYAHuHVtx-0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2018 18:50:27 -0000

MikeBishop approved this pull request.



>  two-bit pattern.  If the entry is in the dynamic table with an absolute index
-greater than Base Index, the representation starts with the '0101' four-bit
+greater than Base Index, the representation starts with the '0000' four-bit
 pattern.

This change is fine, but didn't we separate out the Post-Base things to their own headers?  Did we miss one?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1472#pullrequestreview-131307888