Date: Fri, 22 Jun 2018 11:50:18 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab6011b8853b23ea982a9d9c56fc3b48001f635a7892cf00000001174506ea92a169ce13f7628b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1472/review/131307888@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1472@github.com>
References: <quicwg/base-drafts/pull/1472@github.com>
Subject: Re: [quicwg/base-drafts] Modify codepoints on decoder and
 request/push streams for consistency (#1472)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b2d44ea29f26_4e573fd5d3eeef88110462";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ueE5dKbw2tSA02z-wYAHuHVtx-0>


----==_mimepart_5b2d44ea29f26_4e573fd5d3eeef88110462
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

MikeBishop approved this pull request.



>  two-bit pattern.  If the entry is in the dynamic table with an absolute index
-greater than Base Index, the representation starts with the '0101' four-bit
+greater than Base Index, the representation starts with the '0000' four-bit
 pattern.

This change is fine, but didn't we separate out the Post-Base things to their own headers?  Did we miss one?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1472#pullrequestreview-131307888
----==_mimepart_5b2d44ea29f26_4e573fd5d3eeef88110462
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@MikeBishop</b> approved this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1472#discussion_r197537279">draft-ietf-quic-qpack.md</a>:</p>
<pre style='color:#555'>&gt;  two-bit pattern.  If the entry is in the dynamic table with an absolute index
-greater than Base Index, the representation starts with the &#39;0101&#39; four-bit
+greater than Base Index, the representation starts with the &#39;0000&#39; four-bit
 pattern.
</pre>
<p>This change is fine, but didn't we separate out the Post-Base things to their own headers?  Did we miss one?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1472#pullrequestreview-131307888">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq3gXPgI5bOC0BNNORg8nISstKRQDks5t_TxqgaJpZM4U0QPZ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq_uuTq_sNz5Yvsvb5WRcTLQ--CZLks5t_TxqgaJpZM4U0QPZ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/quicwg/base-drafts/pull/1472#pullrequestreview-131307888","url":"https://github.com/quicwg/base-drafts/pull/1472#pullrequestreview-131307888","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MikeBishop approved #1472"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1472#pullrequestreview-131307888"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@MikeBishop approved 1472",
"sections": [
{
"text": "",
"activityTitle": "**Mike Bishop**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@MikeBishop",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1472#pullrequestreview-131307888"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 349242329\n}"
}
],
"themeColor": "26292E"
}</script>
----==_mimepart_5b2d44ea29f26_4e573fd5d3eeef88110462--