IETF Logo Mail Archive

Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)

ianswett <notifications@github.com> Wed, 06 February 2019 16:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 52FEA130DF6 for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 08:29:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dNsoQV1QN0Vb for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 08:29:09 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA30712D4EB for <quic-issues@ietf.org>; Wed, 6 Feb 2019 08:29:08 -0800 (PST)
Date: Wed, 06 Feb 2019 08:29:07 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549470547; bh=YCPkiXJlg43JT/ACt2GSSTGNbd5FXitHnoSWivsEM70=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=h5/mMERnpnG6jT/SRH6+6/1Nwe4X/c4UjL1a3FTwlzkvg75zLKHDPbMr8+HXS0oBG dVshrsokHmJUQokR/XSJ4UTaFxC+WSsxyTXSTGtXOcNGjQBSTO7PxZId7rKAhbFvg5 Z579WeduJVI6OYUPJEF8yEX4ES/RmkoMxeoRLlCk=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5e6cc551f85fc90218881a2977a205e4ae131e8b92cf000000011872cd5392a169ce183c6fbc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2417/review/200672923@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2417@github.com>
References: <quicwg/base-drafts/pull/2417@github.com>
Subject: Re: [quicwg/base-drafts] update the pseudo code to include packet number spaces (#2417)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5b0b53c37cd_50c33fb56e6d45bc245284"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uf05Bt0CDfY5n2GmQC0kmv0WirQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 16:29:10 -0000

ianswett commented on this pull request.



> @@ -903,20 +915,22 @@ to OnPacketSent are described in detail above in {{sent-packets-fields}}.
 Pseudocode for OnPacketSent follows:
 
 ~~~
- OnPacketSent(packet_number, ack_eliciting, in_flight,
-              is_crypto_packet, sent_bytes):
-   largest_sent_packet = packet_number
-   sent_packets[packet_number].packet_number = packet_number
-   sent_packets[packet_number].time_sent = now
-   sent_packets[packet_number].ack_eliciting = ack_eliciting
-   sent_packets[packet_number].in_flight = in_flight
+ OnPacketSent(packet_number, pn_space, ack_eliciting,

Using pn_space for the variable name and the type is confusing.  I think the enum should be kPacketNumberSpace

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2417#pullrequestreview-200672923

v2.23.0 | Report a Bug | By Email