IETF Logo Mail Archive

Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)

Martin Thomson <notifications@github.com> Mon, 16 October 2017 00:53 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4CDA41332E1 for <quic-issues@ietfa.amsl.com>; Sun, 15 Oct 2017 17:53:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.019
X-Spam-Level:
X-Spam-Status: No, score=-2.019 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AWi-0YMzsNY7 for <quic-issues@ietfa.amsl.com>; Sun, 15 Oct 2017 17:53:24 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 960961332D5 for <quic-issues@ietf.org>; Sun, 15 Oct 2017 17:53:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=kqP052w3q2kqbiDv5nPT8TrYUyg=; b=nht/OJJbRAX7vydJ V2SBFteKgd1FlfdUhRJ3zL5Yj0LfCwKC8CdYSimgb0vGGYFKVfiG9FqGzNNbNO1n obG8ckV3wsrqU2bKvNeoJdHheuHFgBj6P2b0KCHkWkc7s1IwvJHFuV5kGYdj3P2h bgAm2A7JpIRQPsTfs6MH6AeaIGM=
Received: by filter0085p1iad2.sendgrid.net with SMTP id filter0085p1iad2-19971-59E40303-23 2017-10-16 00:53:23.667459491 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0010p1iad2.sendgrid.net (SG) with ESMTP id 08BFxEudQJu7Y2t8FjIh5w for <quic-issues@ietf.org>; Mon, 16 Oct 2017 00:53:23.510 +0000 (UTC)
Date: Mon, 16 Oct 2017 00:53:23 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab411b321add5d435b943b02b17d6ce28d60e3156792cf0000000115fbc50392a169ce0fd14a5e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/872/c336755025@github.com>
In-Reply-To: <quicwg/base-drafts/pull/872@github.com>
References: <quicwg/base-drafts/pull/872@github.com>
Subject: Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59e4030354e01_2f8a3fb1ece04f3880750"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0+icrYWf5xNa2GSKwx/PAAR6+u1HEhvqy8TY QNoRIZuFgxHXlam1p9AbggB3mPQ9mG9Kmi2O13hv/2phI7e1RcyCiZWd0zGg5cdn1gzkBYj+RigsCo O5I99UyYHyoDNEIU5xq7fnX3/p3wcoymqaotqhI/eBNfxLh/bF8YZ808iCNMQhiltN1FDxr6pFnxhj I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ufbHaoc8YnggfBoBko1nxqageyQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 00:53:26 -0000

@mikkelfj, I originally wanted to move the bits to the frame type; but you would need three of each type of frame that mentions streams and there are 6 frame types to modify in that way.  On balance, moving the identification into the same slot that we encode the stream ID as @RyanAtGoogle proposes might be better. That said, the HTTP mapping only uses certain specific types of streams, so maybe it could work out.

I forgot one comment: this PR doesn't address the initial values for MAX_STREAM_ID and MAX_STREAM_DATA.  I think that we should have separate configuration for those.  That suggests that maybe a separate frame type isn't so bad an idea.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/872#issuecomment-336755025

v2.46.0 | Report a Bug | By Email | System Status