IETF Logo Mail Archive

Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)

ianswett <notifications@github.com> Tue, 25 September 2018 16:52 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F0DD128766 for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 09:52:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.999
X-Spam-Level:
X-Spam-Status: No, score=-2.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id My0eomCvUUHf for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 09:52:24 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 64236130DD7 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 09:52:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=AxmL98ontLNXlNbDWrEM8+Mm7j0=; b=oMK8cCgOzMI3R2v+ c6ptdamATQ9TKyJ98BD9TKVieakbKvHZm2fvsKD/UiFUQlm9z24EG3YQOdftg9AK rZfn6WF0IIUISQU0BYBIS0VsyC4rfoUCQ6p5VbpTLgg6YV463tV4T5w0pt8ZQFkh Ihd0NLJ0AV3N8Yw3i5VRByTrpQk=
Received: by filter1505p1mdw1.sendgrid.net with SMTP id filter1505p1mdw1-29538-5BAA67C6-46 2018-09-25 16:52:22.981060419 +0000 UTC m=+1626349.954988980
Received: from github-lowworker-e8fa9ff.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0005p1iad2.sendgrid.net (SG) with ESMTP id PzRsu0eKR-6dgI3Jkkb-BQ for <quic-issues@ietf.org>; Tue, 25 Sep 2018 16:52:23.063 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e8fa9ff.cp1-iad.github.net (Postfix) with ESMTP id DEF3A420348 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 09:52:22 -0700 (PDT)
Date: Tue, 25 Sep 2018 16:52:23 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd7c30c355a04d8e943c080b7430ff76ae6f3e1c892cf0000000117c229c692a169ce15ac2c4e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1796/review/158637248@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1796@github.com>
References: <quicwg/base-drafts/pull/1796@github.com>
Subject: Re: [quicwg/base-drafts] Ack Delay and TLP (#1796)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5baa67c6d7d6e_3583fd992cd45b476942"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0sf0g8EZJL4osAEcag0h8mfQUcWZtipK72N5 VknMMPH2FXwLwgyIcahtHuLQwQUoxBq9rZjQmQKoZMBgfByEqve8HNva8vwg/NwWGmf5Yd5Cq5XtEb IO/VdT9bAH+w8FLpCMozuIvUVrVvu5tiY+aKgPqhajETg75dsvE7NhTGkrV/tgNhFMxZXgjurYxIry Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uhwppkZ1omVKm0KE2L_NFwXIch4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 16:52:26 -0000

ianswett commented on this pull request.

Should I move to 2* kMaxDatagramSize?

> @@ -365,7 +352,11 @@ receiver.
 The timer duration, or Probe Timeout (PTO), is set based on the following
 conditions:
 
-* PTO SHOULD be scheduled for max(1.5*SRTT+MaxAckDelay, kMinTLPTimeout)
+* If less than 2400 bytes are in flight, PTO SHOULD be scheduled for

Yes, but the receiver needs to know the current.  Should I reference kMaxDatagramSize and call that close enough?  I'm fairly concerned that if that changes over the course of the connection, the sender and receiver will not act predictably.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1796#pullrequestreview-158637248

v2.29.0 | Report a Bug | By Email | System Status