Date: Mon, 08 Jun 2020 17:43:20 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKY53ZJJTZBGIXTEYWN45K6CREVBNHHCLIOW54@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3730/review/426713541@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3730@github.com>
References: <quicwg/base-drafts/pull/3730@github.com>
Subject: Re: [quicwg/base-drafts] Gorrys invariant nits (#3730)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ededb28d7d4f_54aa3fc4838cd96c8067";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uoCznlF9DhHTzo7c_8QnSqx-g_0>


----==_mimepart_5ededb28d7d4f_54aa3fc4838cd96c8067
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@ianswett commented on this pull request.

Thanks for changing SCID/DCID to "Source Connection ID" and "Destination Connection ID", that seems like a good change.

> @@ -235,11 +240,11 @@ A connection ID is an opaque field of arbitrary length.
 
 The primary function of a connection ID is to ensure that changes in addressing
 at lower protocol layers (UDP, IP, and below) don't cause packets for a QUIC
-connection to be delivered to the wrong endpoint.  The connection ID is used by
-endpoints and the intermediaries that support them to ensure that each QUIC
-packet can be delivered to the correct instance of an endpoint.  At the
-endpoint, the connection ID is used to identify which QUIC connection the packet
-is intended for.
+connection to be delivered to the wrong transport endpoint.  The connection ID

What's a transport endpoint?  I don't recall us using that term elsewhere, so endpoint seems sufficient to me.  Or maybe we need another term for this case?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3730#pullrequestreview-426713541
----==_mimepart_5ededb28d7d4f_54aa3fc4838cd96c8067
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@ianswett</b> commented on this pull request.</p>

<p>Thanks for changing SCID/DCID to "Source Connection ID" and "Destination Connection ID", that seems like a good change.</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3730#discussion_r437074788">draft-ietf-quic-invariants.md</a>:</p>
<pre style='color:#555'>&gt; @@ -235,11 +240,11 @@ A connection ID is an opaque field of arbitrary length.
 
 The primary function of a connection ID is to ensure that changes in addressing
 at lower protocol layers (UDP, IP, and below) don&#39;t cause packets for a QUIC
-connection to be delivered to the wrong endpoint.  The connection ID is used by
-endpoints and the intermediaries that support them to ensure that each QUIC
-packet can be delivered to the correct instance of an endpoint.  At the
-endpoint, the connection ID is used to identify which QUIC connection the packet
-is intended for.
+connection to be delivered to the wrong transport endpoint.  The connection ID
</pre>
<p>What's a transport endpoint?  I don't recall us using that term elsewhere, so endpoint seems sufficient to me.  Or maybe we need another term for this case?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3730#pullrequestreview-426713541">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK3ZQRMO74JHO7I3MX3RVWASRANCNFSM4NTJBL2A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK6IE6M4DQIWO2QI2VDRVWASRA5CNFSM4NTJBL2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODFXSDRI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3730#pullrequestreview-426713541",
"url": "https://github.com/quicwg/base-drafts/pull/3730#pullrequestreview-426713541",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5ededb28d7d4f_54aa3fc4838cd96c8067--