Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)
ianswett <notifications@github.com> Thu, 30 August 2018 12:24 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DFDDF130E66 for <quic-issues@ietfa.amsl.com>; Thu, 30 Aug 2018 05:24:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8yYNeOnIlrnu for <quic-issues@ietfa.amsl.com>; Thu, 30 Aug 2018 05:24:44 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8443E130E5F for <quic-issues@ietf.org>; Thu, 30 Aug 2018 05:24:44 -0700 (PDT)
Date: Thu, 30 Aug 2018 05:24:43 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1535631883; bh=uLn3O+orvL2UXesCq6T1ZLW2fyjt2NoFhva0+JdBgpY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=L7g45iPtCxVXqjeVv6G1H+YUewKZRWuxeTfemETHFT/yWBSJlXONEl2kc7OQh+6wy bI7cGecIa6e2cSeDX0bsawMw3+MVEUf8n55/qA5ybJoO9F1d+RYSAgfGPkcFd21xva nFW4xrNFE+vr895SjXMc8QEH4qZx9Ci4NfBVat3c=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab88a8527c16afe491efb8b488a030029f6fc8308c92cf00000001179fa40b92a169ce152ea636@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1715/review/150967263@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1715@github.com>
References: <quicwg/base-drafts/pull/1715@github.com>
Subject: Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b87e20b68dc7_404c3fbcfded45b47117d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uv2RdgNPGLaydng6M_m3ZBh0kqA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Aug 2018 12:24:46 -0000
ianswett commented on this pull request. > @@ -3425,6 +3433,10 @@ immediately or when a delayed ack timer expires. The delayed ack timer MUST NOT delay an ACK for longer than an RTT, which ensures an ACK frame is sent at least once per RTT if new packets needing acknowledgement were received. +If the max_bytes_before_ack transport parameter has been received, the +receiver SHOULD send an ACK frame immediately once that many octets of packets +containing frames besides ACK or PADDING have been received. Martin, I tried tweaking your suggested wording, but I failed to come up with something I liked better, so I tweaked what I had. FWIW, I'm really tired of saying "Except ACK and PADDING" everywhere, so I I'll probably try to tackle that issue(#1595) soon. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1715#discussion_r214009306
- [quicwg/base-drafts] Add max_bytes_before_ack to … ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… Martin Thomson
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… MikkelFJ
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… Christian Huitema
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… Christoph Paasch
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… Christian Huitema
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… Christian Huitema
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… Magnus Westerlund
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett
- Re: [quicwg/base-drafts] Add max_bytes_before_ack… ianswett