Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)

Martin Thomson <notifications@github.com> Wed, 11 March 2020 00:43 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1A6A03A0CAF for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 17:43:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QUePe2BZ1WaA for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 17:43:50 -0700 (PDT)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C0803A0CAA for <quic-issues@ietf.org>; Tue, 10 Mar 2020 17:43:50 -0700 (PDT)
Received: from github-lowworker-25680bd.va3-iad.github.net (github-lowworker-25680bd.va3-iad.github.net [10.48.17.61]) by smtp.github.com (Postfix) with ESMTP id DEA0A120292 for <quic-issues@ietf.org>; Tue, 10 Mar 2020 17:43:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583887429; bh=3YS+ybw5RS8/gHCjrnIwM9vdyNvAiOV8XP5hAOapQ9w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bTpUqphBwIs5SHaH4J8IvgRiylqTNo/p26ty6VFiK4HF2sT4SlFKIwvDfl4k2+bQV cwczen9J5BcNFr7Q49mJwSI33MtSd7ZJKGk/4paUXTGbdvM0KwYRdIF9DtzM/r6MMP ZiDf1SiC46jtYjyqGJdk3F/E1375HdAQzJGCNR8A=
Date: Tue, 10 Mar 2020 17:43:49 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7Y3C2PE5K4K3KJAX54OQKULEVBNHHCDZCX6I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3473/review/372410651@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3473@github.com>
References: <quicwg/base-drafts/pull/3473@github.com>
Subject: Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e68344599441_38e43ffc198cd96c1284a7"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uvQEcZwlJQAVnq_yTT4m47pLBsQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2020 00:43:52 -0000

martinthomson commented on this pull request.

I want to add to this.

>  
-: The maximum packet size parameter is an integer value that limits the size of
-  packets that the endpoint is willing to receive.  This indicates that packets
-  larger than this limit will be dropped.  The default for this parameter is the
-  maximum permitted UDP payload of 65527.  Values below 1200 are invalid.  This
-  limit only applies to protected packets ({{packet-protected}}).
+: The maximum UDP payload size parameter is an integer value that limits the
+  size of UDP payloads that the endpoint is willing to receive.  UDP packets
+  with payloads larger than this limit are not likely to be processed by the
+  receiver.
+
+  The default for this parameter is the maximum permitted UDP payload of 65527.
+  Values below 1200 are invalid.
 

```suggestion

: This limit does act as an additional constraint on datagram size in the same
  way as the path MTU, but it is a property of the endpoint and not the path. It
  is expected that this is the space an endpoint dedicates to holding incoming
  packets.
```

>  
-: The maximum packet size parameter is an integer value that limits the size of
-  packets that the endpoint is willing to receive.  This indicates that packets
-  larger than this limit will be dropped.  The default for this parameter is the
-  maximum permitted UDP payload of 65527.  Values below 1200 are invalid.  This
-  limit only applies to protected packets ({{packet-protected}}).
+: The maximum UDP payload size parameter is an integer value that limits the
+  size of UDP payloads that the endpoint is willing to receive.  UDP packets
+  with payloads larger than this limit are not likely to be processed by the
+  receiver.
+
+  The default for this parameter is the maximum permitted UDP payload of 65527.

```suggestion
: The default for this parameter is the maximum permitted UDP payload of 65527.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3473#pullrequestreview-372410651