Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

ianswett <notifications@github.com> Tue, 29 January 2019 10:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 08681130F52 for <quic-issues@ietfa.amsl.com>; Tue, 29 Jan 2019 02:48:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.552
X-Spam-Level:
X-Spam-Status: No, score=-7.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LaSX7AZ4SU5i for <quic-issues@ietfa.amsl.com>; Tue, 29 Jan 2019 02:48:18 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D270D130F4D for <quic-issues@ietf.org>; Tue, 29 Jan 2019 02:48:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=/uQFB8bu4PRNizqWd32F1fFIsgw=; b=lRFyTGfyzz9c9oBq Ws3KQEUXVeuYdNHWmwY5t+WOoIKogGgMG41JNTuHw3/MCWuqobls76JeXDJ/72oz g6ozM7uk/Z+A8c8MOj5jq0kav38qNrBFHJAcfkNPqvPxguWglwFIo7WXf11UBkWB jiVBBe9zmUxcpkjxhQIkTsQPqj8=
Received: by filter1330p1mdw1.sendgrid.net with SMTP id filter1330p1mdw1-20071-5C502F70-23 2019-01-29 10:48:16.926441474 +0000 UTC m=+45254.243297415
Received: from github-lowworker-05ceafd.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0018p1iad2.sendgrid.net (SG) with ESMTP id 41taJJChSEmSRrF86QywBA for <quic-issues@ietf.org>; Tue, 29 Jan 2019 10:48:16.858 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-05ceafd.cp1-iad.github.net (Postfix) with ESMTP id D620F460BF7 for <quic-issues@ietf.org>; Tue, 29 Jan 2019 02:48:16 -0800 (PST)
Date: Tue, 29 Jan 2019 10:48:16 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0bfff1ae99f59e3cebd52c2a9a2f02013f33934092cf000000011867f17092a169ce17fab1f6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2365/review/197486828@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2365@github.com>
References: <quicwg/base-drafts/pull/2365@github.com>
Subject: Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c502f70d48a1_50393fcddb8d45bc33311e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3XO4pHEvUefbJansFHT10RGXe4GUzeQ5cX+w jEHQ1f+1L6wROTbvsozUN8KnhRn7s8KTVQCUDQWpK8quveDOhrtHggdKwYhfV1btwm/dt21+IEPqnw GsEzfsSsREzjTIsZ0ijrVzFLziTWoH84JVenxOGKN1DC8D8vizQQu2mcUwp0ilt6dSPL1PnzM/N8Sq c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/v-58mVVELYrQVtryXK2rb4S6IQk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jan 2019 10:48:20 -0000

ianswett commented on this pull request.



>  When an ACK frame is received that establishes loss of all in-flight packets
-sent prior to a threshold number of consecutive PTOs (pto_count is more than
-kPersistentCongestionThreshold, see {{cc-consts-of-interest}}), the network is
-considered to be experiencing persistent congestion, and the sender's congestion
-window MUST be reduced to the minimum congestion window (kMinimumWindow).  This
-response of collapsing the congestion window on persistent congestion is
-functionally similar to a sender's response on a Retransmission Timeout (RTO) in
-TCP {{RFC5681}}.
+sent over a long enough period of time, the network is considered to be
+experiencing persistent congestion.  Commonly, this can be established by
+consecutive PTOs (pto_count is more than  kPersistentCongestionThreshold, see
+{{cc-consts-of-interest}}), but since the PTO timer is reset when a new
+ack-eliciting packet is sent, an explicit timeout must be used to account for
+those cases where PTOs do not occur.

```suggestion
those cases where PTOs do not occur or are substantially delayed.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365#pullrequestreview-197486828