Date: Thu, 11 Jul 2019 17:39:53 -0700
From: =?UTF-8?B?QmVuY2UgQsOpa3k=?= <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2OWULYLVJZ5ETKH553GUEVTEVBNHHBXWDFAA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2892@github.com>
Subject: [quicwg/base-drafts] QPACK Required Insert Count decoding pseudocode
 does not enforce that encoding is valid (#2892)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d27d6d962632_76a93f90a0acd968208124c";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/v0gpCyDZvKUkqVrl-CEKz11_Yyc>


----==_mimepart_5d27d6d962632_76a93f90a0acd968208124c
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

Consider the following example:
MaxEntries = 8
TotalNumberOfInserts = 4
EncInsertCount = 1

Applying the decoder pseudocode yields ReqInsertCount = 0 without signalling an error.  However, the encoder should have encoded that as EncInsertCount = 0, therefore the decoder should signal an error according to the text: "If the decoder encounters a value of EncodedInsertCount that could not have been produced by a conformant encoder, it MUST treat this as a connection error of type HTTP_QPACK_DECOMPRESSION_FAILED."

The text is considered normative and the pseudocode is not.  To help decoder implementations be conformant, the pseudocode should be updated to signal an error in this case.  Adding the following two lines would be a correct solution:

    if ReqInsertCount == 0:
      Error

However, this introduces an extra branch.  It would be nice to find a more elegant decoding algorithm.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2892
----==_mimepart_5d27d6d962632_76a93f90a0acd968208124c
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>Consider the following example:<br>
MaxEntries = 8<br>
TotalNumberOfInserts = 4<br>
EncInsertCount = 1</p>
<p>Applying the decoder pseudocode yields ReqInsertCount = 0 without signalling an error.  However, the encoder should have encoded that as EncInsertCount = 0, therefore the decoder should signal an error according to the text: "If the decoder encounters a value of EncodedInsertCount that could not have been produced by a conformant encoder, it MUST treat this as a connection error of type HTTP_QPACK_DECOMPRESSION_FAILED."</p>
<p>The text is considered normative and the pseudocode is not.  To help decoder implementations be conformant, the pseudocode should be updated to signal an error in this case.  Adding the following two lines would be a correct solution:</p>
<pre><code>if ReqInsertCount == 0:
  Error
</code></pre>
<p>However, this introduces an extra branch.  It would be nice to find a more elegant decoding algorithm.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/issues/2892?email_source=notifications&amp;email_token=AFTOJK7HDT27ONU7527M6XTP67HFTA5CNFSM4IB3ZMTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6YMUAA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK3AKPF7DJCB4GQWTALP67HFTANCNFSM4IB3ZMTA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK74FV2MQ4UDYXWAFQLP67HFTA5CNFSM4IB3ZMTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6YMUAA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/2892?email_source=notifications\u0026email_token=AFTOJK7HDT27ONU7527M6XTP67HFTA5CNFSM4IB3ZMTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6YMUAA",
"url": "https://github.com/quicwg/base-drafts/issues/2892?email_source=notifications\u0026email_token=AFTOJK7HDT27ONU7527M6XTP67HFTA5CNFSM4IB3ZMTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6YMUAA",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5d27d6d962632_76a93f90a0acd968208124c--