Re: [quicwg/base-drafts] Allow endpoints to generate traffic keys asynchronously (#3874)

Kazuho Oku <notifications@github.com> Thu, 09 July 2020 03:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD7A33A0E45 for <quic-issues@ietfa.amsl.com>; Wed, 8 Jul 2020 20:37:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.696
X-Spam-Level:
X-Spam-Status: No, score=-6.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BUOIeWfKyzvn for <quic-issues@ietfa.amsl.com>; Wed, 8 Jul 2020 20:37:14 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 710BF3A0E3D for <quic-issues@ietf.org>; Wed, 8 Jul 2020 20:37:14 -0700 (PDT)
Received: from github-lowworker-0eea13f.ash1-iad.github.net (github-lowworker-0eea13f.ash1-iad.github.net [10.56.109.26]) by smtp.github.com (Postfix) with ESMTP id 976B8E17F5 for <quic-issues@ietf.org>; Wed, 8 Jul 2020 20:37:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594265832; bh=tCTkgVRgBtw5kezgJ22ASV2WsE6qYH1/H9NtjJcyJYI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=w8lzK1Hkfxu1PUSLgrLx6/n3kshFoM0OwUDpEhBTQylwCy3ULuzmIFSvPQfzT3sAl bHyDkrZ6y29ulsjm5KR+axqDrqcugiAh2FxzzphfgEvDVeIZFkBscbOaSm9hiyg48B aPues5uAzQv46wrCSawTIZ5CMTNfvxvhWY7BZnsk=
Date: Wed, 08 Jul 2020 20:37:12 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4QTIWYQP2HEBLFY555CJY6REVBNHHCN3MY3A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3874/review/445268376@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3874@github.com>
References: <quicwg/base-drafts/pull/3874@github.com>
Subject: Re: [quicwg/base-drafts] Allow endpoints to generate traffic keys asynchronously (#3874)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0690e888948_18613f9c4d4cd9602236b5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/v57vg9SwKQBpEn3ozPhrow8vf_c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2020 03:37:16 -0000

@kazuho commented on this pull request.



> @@ -501,9 +501,11 @@ handshake, new data is requested from TLS after providing received data.
 As keys for new encryption levels become available, TLS provides QUIC with those
 keys.  Separately, as keys at a given encryption level become available to TLS,
 TLS indicates to QUIC that reading or writing keys at that encryption level are
-available.  These events are not asynchronous; they always occur immediately
-after TLS is provided with new handshake bytes, or after TLS produces handshake
-bytes.
+available.  While waiting for TLS to provide these keys, an endpoint SHOULD
+buffer the received packets marked as protected by the keys yet to be provided,
+and process them once those keys become available.  If the keys are generated
+asynchronously, an endpoint MAY continue responding to the received packets that
+are processable while waiting for TLS to provide these keys.

Thanks, I agree that that's better. Applied in 16038c1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3874#discussion_r451945094