Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B80BB130FF5 for ; Tue, 11 Dec 2018 18:22:51 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -8.056 X-Spam-Level: X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f1nA-nF7JsDC for ; Tue, 11 Dec 2018 18:22:49 -0800 (PST) Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDF72130FED for ; Tue, 11 Dec 2018 18:22:49 -0800 (PST) Date: Tue, 11 Dec 2018 18:22:48 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544581369; bh=fxylInoe+MS+oMPS/QJP6vz9qH1SbiJbWmdIYhpvsGI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oxd/5n+yxKvJKr9nTbomlSvohBuj/+0RN6bIvlic2ldstmyEHKV4fxoX2KU0gyz6E yqr23LgYabR9/VtSkemaPa7ilrm3sil2zlD3rJcpmHAw7Bv1wIXTNQ9Ul3Q/yrwlQA 8d8q63mXzLfLGjjt71u5H+lVXds4SCl7XlQHPAVo= From: ianswett Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Ack-eliciting, not inflight (#2117) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c1070f8c0987_24153fdb79ed45c444799c"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ianswett X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 02:22:52 -0000 ----==_mimepart_5c1070f8c0987_24153fdb79ed45c444799c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ianswett commented on this pull request. > @@ -792,7 +792,7 @@ Pseudocode for SetLossDetectionTimer follows: SetLossDetectionTimer(): // Don't arm timer if there are no ack-eliciting packets // in flight. - if (bytes_in_flight == 0): + if (no ack-eliciting packets oustanding): We never define what outstanding means, from what I can find, though we do use in a few spots. In this case, I believe it should be "no ack-eliciting packets In-flight"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2117#pullrequestreview-183989952 ----==_mimepart_5c1070f8c0987_24153fdb79ed45c444799c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@ianswett commented on this pull request.

In draft-ietf-quic-recovery.md:

> @@ -792,7 +792,7 @@ Pseudocode for SetLossDetectionTimer follows:
  SetLossDetectionTimer():
     // Don't arm timer if there are no ack-eliciting packets
     // in flight.
-    if (bytes_in_flight == 0):
+    if (no ack-eliciting packets oustanding):

We never define what outstanding means, from what I can find, though we do use in a few spots. In this case, I believe it should be "no ack-eliciting packets In-flight"?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5c1070f8c0987_24153fdb79ed45c444799c--