Re: [quicwg/base-drafts] Use "Insert Count" rather than "Largest Reference" (#2111)

Martin Thomson <notifications@github.com> Wed, 09 January 2019 02:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9804712008A for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 18:39:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.447
X-Spam-Level:
X-Spam-Status: No, score=-6.447 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ci3PPXV_cyvW for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 18:39:05 -0800 (PST)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BCC7412D7EA for <quic-issues@ietf.org>; Tue, 8 Jan 2019 18:39:04 -0800 (PST)
Date: Tue, 08 Jan 2019 18:39:03 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547001544; bh=a+/5XkrhvvAoRKZHeVhoQLsbJscCijtGf8+i3WSZSz4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=g1DCSLBvwiz4NG/cb3iuxWn+8y/fdrTPSUP4xftH7ulYNkfHLYVNtZnnMUNdP8cTe +Npd18WcL6zaDN6IF2xs9ucKxtdkXCPzaWpWK4UZ1BsIPToyTURh3MJK6HsH5sjtQS CfhgByZtKxn5cOFTL4QWBJ6KG5dIX6pCw5aP66Q8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb8330b7c0c945d133a72481e0e45ac875eb451e492cf00000001184d20c792a169ce17392ee3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2111/review/190554593@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2111@github.com>
References: <quicwg/base-drafts/pull/2111@github.com>
Subject: Re: [quicwg/base-drafts] Use "Insert Count" rather than "Largest Reference" (#2111)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c355ec7c5da8_6e533fb01b0d45c020785"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/v5d5XUnsqw5Yi467TKNM_XRqlKo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 02:39:06 -0000

martinthomson commented on this pull request.

I think that I got all the "the Base" updated.

I don't know if this needs to be a more specific term.  Using "count" in the name is somewhat right, but it's a concept that probably doesn't need to be globally unique as it is only used in the scope of decoding header blocks.

I'll leave that to editorial discretion though, that's just my opinion.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2111#pullrequestreview-190554593