Re: [quicwg/base-drafts] Fix congestion control permissiveness (#3248)

ianswett <notifications@github.com> Sun, 17 November 2019 07:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8F6D1200B2 for <quic-issues@ietfa.amsl.com>; Sat, 16 Nov 2019 23:15:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LrC47ifwoP9N for <quic-issues@ietfa.amsl.com>; Sat, 16 Nov 2019 23:15:00 -0800 (PST)
Received: from out-13.smtp.github.com (out-13.smtp.github.com [192.30.254.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B5721200A1 for <quic-issues@ietf.org>; Sat, 16 Nov 2019 23:15:00 -0800 (PST)
Received: from github-lowworker-6349a71.ac4-iad.github.net (github-lowworker-6349a71.ac4-iad.github.net [10.52.18.20]) by smtp.github.com (Postfix) with ESMTP id DCAD32615BB for <quic-issues@ietf.org>; Sat, 16 Nov 2019 23:14:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573974899; bh=pR5Hwu8NA7nCJ6xmQCD6G73pVtKCyvI6+wfoid1wU8w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=suSysOcCNvHMYsjnmR8yjaJ/IogznR7hMCgdHKzFDS84Xse+pVIWjm+1EypcghS1W czsqo33AFHpFmAy352jZDk4m9fXCxl1KUXBRnB6bnjQhIGBgAZBv/8HKdQxNARJd5X e71xIanUhWUwRbILEycJv7F03BZSuG9O832xMpRo=
Date: Sat, 16 Nov 2019 23:14:59 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4D6T3B4DLOKLEPWXV33YS7HEVBNHHB6OVESM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3248/review/318004227@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3248@github.com>
References: <quicwg/base-drafts/pull/3248@github.com>
Subject: Re: [quicwg/base-drafts] Fix congestion control permissiveness (#3248)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd0f37394a11_69be3fe05c6cd96024244f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vEk7jrIhEIM4aSvsiTL75DBj_Mw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 07:15:02 -0000

ianswett commented on this pull request.



>  
-Implementations MAY use other congestion control algorithms, such as
-Cubic {{?RFC8312}}, and endpoints MAY use different algorithms from one another.
-The signals QUIC provides for congestion control are generic and are designed
-to support different algorithms.
+If an endpoint uses a different controller than that specified in this document,
+it MUST conform to the congestion control guidelines specified in {{!RFC8085}}.
+
+The algorithm in this document specifies and uses the controller's congestion
+window in bytes.
+
+An endpoint MUST NOT send a packet if it would cause bytes_in_flight (see
+{{vars-of-interest}}) to be larger than the congestion window, unless the packet
+is a probe sent on a PTO timer expiration (see {{pto}}).

```suggestion
is sent on a PTO timer expiration (see {{pto}}).
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3248#pullrequestreview-318004227