IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)

ianswett <notifications@github.com> Sun, 18 March 2018 09:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6C84712778E for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:47:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.392
X-Spam-Level:
X-Spam-Status: No, score=-5.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DQoCPuMmWc8c for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:47:31 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC37612741D for <quic-issues@ietf.org>; Sun, 18 Mar 2018 02:47:31 -0700 (PDT)
Date: Sun, 18 Mar 2018 02:47:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521366451; bh=cFIIbvvqyKuDLRVsyeDmgCH15iPlYpafZwZO9dt9ohs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ust/DUo+Gn3iqSSuCB5CA9Oq82np6zqSwka7dUTdJvoN66QUycyFM+hu2mcpW47BQ /5tmhlw3WiBPl3DlNjlUQJxtjrc2PFXnC/pi86sEAPulLaLQgBXk71gIc8vavJwhJM k6QOdobWmUf+DSC8Cn90ianzo/eR4inWQi0Mc/8k=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abeca698ca7fb19e71c35cedc9d1c13af03a21a67e92cf0000000116c5f7b392a169ce123fc47f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1223/review/104791358@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1223@github.com>
References: <quicwg/base-drafts/pull/1223@github.com>
Subject: Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae35b327c59_4dde2b1a4456aed0185194"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vG_8FoRlKmQRUOhPX8ASan5reGE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 09:47:33 -0000

ianswett commented on this pull request.



> @@ -1039,11 +1038,11 @@ Invoked by loss detection from DetectLostPackets when new packets
 are detected lost.
 
 ~~~
-   OnPacketsLost(lost_packets):
+   OnPacketsLost(lost_packet):

Did you accidentally change lost_packets to lost_packet?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1223#pullrequestreview-104791358

v2.27.8 | Report a Bug | By Email | System Status