Re: [quicwg/base-drafts] Increase resilience to spoofed Version Negotiation packets (#524)
janaiyengar <notifications@github.com> Tue, 16 May 2017 23:23 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 952381273B1 for <quic-issues@ietfa.amsl.com>; Tue, 16 May 2017 16:23:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.595
X-Spam-Level:
X-Spam-Status: No, score=-5.595 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T_uDHmpM-u00 for <quic-issues@ietfa.amsl.com>; Tue, 16 May 2017 16:23:10 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext1.iad.github.net [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A8A512EC80 for <quic-issues@ietf.org>; Tue, 16 May 2017 16:19:07 -0700 (PDT)
Date: Tue, 16 May 2017 16:19:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1494976746; bh=EP12iwNXYY9pMnG5+W/7dl8XFwxEz+uoi/jyctn8C5s=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ysdz6Irycb2fElAyVsiOLwyucOLhN6ULFKSdwbSHCwyuBX9XQ4152MvE1DtnSz1us 4ngrZ0ILodwEIyqfAM4kgn8Qj6QqML05xV3XgkxMDtE9HGiP5ZFCdYzA6mFxxUpJ30 2PGFvXF49D57zvBpL4F8R3A66Nnhs+Wk6FVodMrE=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf9ec16cf5a03c70f68f4ba4e9235eb9fe329755c92cf0000000115334aea92a169ce0d99fec5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/524/review/38537358@github.com>
In-Reply-To: <quicwg/base-drafts/pull/524@github.com>
References: <quicwg/base-drafts/pull/524@github.com>
Subject: Re: [quicwg/base-drafts] Increase resilience to spoofed Version Negotiation packets (#524)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_591b88eaba429_1a7d3f8ade583c2c28364"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vL6hFcgXWkz0Ay3xYaJYHkeNEMU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 May 2017 23:23:12 -0000
janaiyengar commented on this pull request. > @@ -1228,6 +1235,18 @@ client MUST terminate with a QUIC_VERSION_NEGOTIATION_MISMATCH error code if version negotiation occurred but it would have selected a different version based on the value of the supported_versions list. +If the client receives a Version Negotiation packet and these validation checks +subsequently fail, it is likely that the client received a spoofed Version +Negotiation packet. A client MAY attempt to create a new connection and ignore +any Version Negotiation packets that match those that caused the connection to +fail. + +Note: + +: The client cannot rely on the version list from the transport parameters. The client has to rely on the list; it just cannot validate the list until the end of the handshake. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/524#discussion_r116880354
- [quicwg/base-drafts] Increase resilience to spoof… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… Mike Bishop
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… janaiyengar
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… MikkelFJ
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson
- Re: [quicwg/base-drafts] Increase resilience to s… Martin Thomson