Re: [quicwg/base-drafts] Clarified how to specify missing packets (#647)

Martin Thomson <notifications@github.com> Wed, 21 June 2017 02:52 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C69C6131560 for <quic-issues@ietfa.amsl.com>; Tue, 20 Jun 2017 19:52:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.182
X-Spam-Level:
X-Spam-Status: No, score=-3.182 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dy9FaxRDsp7G for <quic-issues@ietfa.amsl.com>; Tue, 20 Jun 2017 19:52:58 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A849126B6E for <quic-issues@ietf.org>; Tue, 20 Jun 2017 19:52:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=eXfPXDoMl2+gtoUqtf/auij4vIw=; b=LSQwGIG0d62sukjE PLtMUnol7aafabJyPhBm6uQXYyoFZVJBMzZmRFTSfhrWHEwLKmA74Bui9LzOXLzp kRsmhlLnpzvmCrEpkvFgdWMlg1pbVFeovyVOpDaByRaIGfff7TZ7pVG1sY8wQLcJ ih68KhzN9/mJPUYaZ1h+ZgOKB/k=
Received: by filter0486p1mdw1.sendgrid.net with SMTP id filter0486p1mdw1-17255-5949DF88-35 2017-06-21 02:52:56.635808872 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id hCPK8jWPS9eOfTZ_juPtXg for <quic-issues@ietf.org>; Wed, 21 Jun 2017 02:52:56.552 +0000 (UTC)
Date: Tue, 20 Jun 2017 19:52:56 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4a68f36dd0a6e08fecdefc1372aeec7bdefb39dd92cf000000011561a18892a169ce0e264a29@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/647/review/45317533@github.com>
In-Reply-To: <quicwg/base-drafts/pull/647@github.com>
References: <quicwg/base-drafts/pull/647@github.com>
Subject: Re: [quicwg/base-drafts] Clarified how to specify missing packets (#647)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5949df8870299_36913fa88fae3c34686d4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3wb7nFzFg5xZISeZcvX+jhV/LhpoZIYeG2yZ R7vbSG9FN6BmrVgrSe7aoylAJi/9Cdk/bdv2XoXM1kv3UikB4Uj9TjKhYt7rYYL5wXXtj9+Kq9WPIN F++3Q/MuPTO/FkMg6qdlFf+T8XLonfb2d6xc8QdzO9QLXoa7k8G7B6MZLvL8Ma2bik9eaOiDsMX2GG U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vLM2btKQpbrSmT-C5nH3h87MWfA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jun 2017 02:53:00 -0000

martinthomson requested changes on this pull request.

This is a grossly inefficient encoding, but at the point where you have a 255 packet gap, efficiency is probably out the window anyway.

Don't we also have to say that the gap can be 0 also?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/647#pullrequestreview-45317533