IETF Logo Mail Archive

Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)

ekr <notifications@github.com> Mon, 19 March 2018 08:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15C3E124E15 for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 01:02:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.605
X-Spam-Level:
X-Spam-Status: No, score=-5.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u1l-mIuam9A0 for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 01:02:52 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A3B8F120227 for <quic-issues@ietf.org>; Mon, 19 Mar 2018 01:02:52 -0700 (PDT)
Date: Mon, 19 Mar 2018 01:02:51 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521446571; bh=ohJweG73HccSfUG/C8mQRUb2+eAieHb2/byoduBYryw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZjNu7xzyQo+5sRp2MdNZCohjUJdBVDykRuboU9v2NvNqwcd67SqZV4uUe6dQfB0lL dyADozFL/GeKhNenFMzOYquAN793VFCA9sSk3YA9t7YHV8MGqmyPaEvm88k85IYHjR giFY2yo68+g8JUB9QvqyXNjBtP3BOlB6qnSuuvio=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6fa1584e8b8e7911559e5e5ba241f9381af5ed1792cf0000000116c730ab92a169ce12418d6a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1231/review/104865088@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1231@github.com>
References: <quicwg/base-drafts/pull/1231@github.com>
Subject: Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aaf6eaba5947_29ca2b01f796ced07054ad"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vLfQ-HPqSqf98Dhe9nX3Z0qVDU4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 08:02:54 -0000

ekr commented on this pull request.



> @@ -2538,10 +2538,10 @@ ACK Block (repeated):
 Implementations MUST NOT generate packets that only contain ACK frames in
 response to packets which only contain ACK frames. However, they MUST
 acknowledge packets containing only ACK frames when sending ACK frames in
-response to other packets.  Implementations MUST NOT send more than one ACK
-frame per received packet that contains frames other than ACK frames.  Packets
-containing non-ACK frames MUST be acknowledged immediately or when a delayed
-ack timer expires.
+response to other packets.  Implementations MUST NOT send more than one packet
+containing only ACK frames per received packet that contains frames other than

No. It was purely that the text didn't match my expectations

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1231#discussion_r175352821

v2.46.0 | Report a Bug | By Email | System Status