IETF Logo Mail Archive

Re: [quicwg/base-drafts] create codec streams only when necessary (#2090)

Kazuho Oku <notifications@github.com> Wed, 05 December 2018 09:04 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 501D4130F97 for <quic-issues@ietfa.amsl.com>; Wed, 5 Dec 2018 01:04:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MA1q8b_imXxU for <quic-issues@ietfa.amsl.com>; Wed, 5 Dec 2018 01:04:18 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9947130E8A for <quic-issues@ietf.org>; Wed, 5 Dec 2018 01:04:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=CjvtQ5hvM35/1UWewhKrpq2NbaE=; b=O/Mn+HDykpG2tId/ zL2iQMHQfk/uTGvR+vwsi1tmQ6hTxMyW2/j+ZR6SmyFZBzRyJTELHm6OxU3qDoCl +4hzsgWM7W+eUZwagwA4wnKo/NnmX86+ZTAUsa97+d2GBCpjH8gNTqEM0JhVY4c8 OGa8KSotrqD5VMG6o/76yYbn2vQ=
Received: by filter0495p1iad2.sendgrid.net with SMTP id filter0495p1iad2-22756-5C079490-B 2018-12-05 09:04:16.575367106 +0000 UTC m=+113617.501901138
Received: from github-lowworker-0b1e58d.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0009p1iad2.sendgrid.net (SG) with ESMTP id VNXhe66-RsWfmUiOotpm2w for <quic-issues@ietf.org>; Wed, 05 Dec 2018 09:04:16.574 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-0b1e58d.cp1-iad.github.net (Postfix) with ESMTP id 8B0CE3E00F5 for <quic-issues@ietf.org>; Wed, 5 Dec 2018 01:04:16 -0800 (PST)
Date: Wed, 05 Dec 2018 09:04:16 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab54c23276af5145031bcc8d2d35fa5db7c5338ae892cf00000001181f569092a169ce170ba08e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2090/review/181648743@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2090@github.com>
References: <quicwg/base-drafts/pull/2090@github.com>
Subject: Re: [quicwg/base-drafts] create codec streams only when necessary (#2090)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c07949089a59_664c3fbf25ed45bc75532"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1kWPck6p4zQdOF0/DThlzGkk0PqiIoOer1kF 67wOUpaZjkyhgZDAeUjcEEaujxPRw9XXs5Awi9MpW1l8i+4qtEyriNYelUflglc4sQC+S8ta7r6SDP jdQGwwB2ySe7M6TpXh4VXO96p83ewNsGwNuKSIaWp+4ETtzeox6Eilro3XTqCLK1VaBXGq/HsmgxGD 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vQ2j-q7A4X3rUEFKGt3AH0vdqfw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2018 09:04:27 -0000

kazuho commented on this pull request.



>  Receipt of a second instance of either stream type MUST be treated as a
 connection error of HTTP_WRONG_STREAM_COUNT.  Closure of either unidirectional
 stream MUST be treated as a connection error of type
 HTTP_CLOSED_CRITICAL_STREAM.
 
+An endpoint MUST NOT create an encoder stream if the maximum size of the
+dynamic table permitted by the peer is zero.  Observation of a peer-initiated
+encoder stream when the value is zero MUST be treated as a connection error of

Thank you for the suggestions. Applied in 0ea3696.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2090#discussion_r238978583

v2.23.0 | Report a Bug | By Email